Browse Source

remove CR/LF from .gitignore

For everyone cursed by dos/windows line endings (aka CRLF):

The code reading the .gitignore files (excludes and excludes per
directory) leaves \r in the patterns, which causes fnmatch to fail for
no obvious reason. Just remove a "\r" preceding a "\n"
unconditionally.

Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Alex Riesen 20 years ago committed by Junio C Hamano
parent
commit
d317e4384a
  1. 2
      ls-files.c
  2. 12
      t/t3001-ls-files-others-exclude.sh

2
ls-files.c

@ -97,7 +97,7 @@ static int add_excludes_from_file_1(const char *fname,
for (i = 0; i < size; i++) { for (i = 0; i < size; i++) {
if (buf[i] == '\n') { if (buf[i] == '\n') {
if (entry != buf + i && entry[0] != '#') { if (entry != buf + i && entry[0] != '#') {
buf[i] = 0; buf[i - (i && buf[i-1] == '\r')] = 0;
add_exclude(entry, base, baselen, which); add_exclude(entry, base, baselen, which);
} }
entry = buf + i + 1; entry = buf + i + 1;

12
t/t3001-ls-files-others-exclude.sh

@ -67,4 +67,16 @@ test_expect_success \
>output && >output &&
diff -u expect output' diff -u expect output'


# Test \r\n (MSDOS-like systems)
echo -ne '*.1\r\n/*.3\r\n!*.6\r\n' >.gitignore

test_expect_success \
'git-ls-files --others with \r\n line endings.' \
'git-ls-files --others \
--exclude=\*.6 \
--exclude-per-directory=.gitignore \
--exclude-from=.git/ignore \
>output &&
diff -u expect output'

test_done test_done

Loading…
Cancel
Save