Reorder diff_opt_parse options more logically per topics.
This is a line reordering patch _only_. Signed-off-by: Pierre Habouzit <madcoder@debian.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>maint
							parent
							
								
									8f67f8aefb
								
							
						
					
					
						commit
						d054680c7d
					
				
							
								
								
									
										126
									
								
								diff.c
								
								
								
								
							
							
						
						
									
										126
									
								
								diff.c
								
								
								
								
							| 
						 | 
				
			
			@ -2185,6 +2185,8 @@ static int diff_scoreopt_parse(const char *opt);
 | 
			
		|||
int diff_opt_parse(struct diff_options *options, const char **av, int ac)
 | 
			
		||||
{
 | 
			
		||||
	const char *arg = av[0];
 | 
			
		||||
 | 
			
		||||
	/* Output format options */
 | 
			
		||||
	if (!strcmp(arg, "-p") || !strcmp(arg, "-u"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_PATCH;
 | 
			
		||||
	else if (opt_arg(arg, 'U', "unified", &options->context))
 | 
			
		||||
| 
						 | 
				
			
			@ -2197,6 +2199,18 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)
 | 
			
		|||
		options->output_format |= DIFF_FORMAT_NUMSTAT;
 | 
			
		||||
	else if (!strcmp(arg, "--shortstat"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_SHORTSTAT;
 | 
			
		||||
	else if (!strcmp(arg, "--check"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_CHECKDIFF;
 | 
			
		||||
	else if (!strcmp(arg, "--summary"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_SUMMARY;
 | 
			
		||||
	else if (!strcmp(arg, "--patch-with-stat"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_PATCH | DIFF_FORMAT_DIFFSTAT;
 | 
			
		||||
	else if (!strcmp(arg, "--name-only"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_NAME;
 | 
			
		||||
	else if (!strcmp(arg, "--name-status"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_NAME_STATUS;
 | 
			
		||||
	else if (!strcmp(arg, "-s"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_NO_OUTPUT;
 | 
			
		||||
	else if (!prefixcmp(arg, "--stat")) {
 | 
			
		||||
		char *end;
 | 
			
		||||
		int width = options->stat_width;
 | 
			
		||||
| 
						 | 
				
			
			@ -2224,42 +2238,8 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)
 | 
			
		|||
		options->stat_name_width = name_width;
 | 
			
		||||
		options->stat_width = width;
 | 
			
		||||
	}
 | 
			
		||||
	else if (!strcmp(arg, "--check"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_CHECKDIFF;
 | 
			
		||||
	else if (!strcmp(arg, "--summary"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_SUMMARY;
 | 
			
		||||
	else if (!strcmp(arg, "--patch-with-stat"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_PATCH | DIFF_FORMAT_DIFFSTAT;
 | 
			
		||||
	else if (!strcmp(arg, "-z"))
 | 
			
		||||
		options->line_termination = 0;
 | 
			
		||||
	else if (!prefixcmp(arg, "-l"))
 | 
			
		||||
		options->rename_limit = strtoul(arg+2, NULL, 10);
 | 
			
		||||
	else if (!strcmp(arg, "--full-index"))
 | 
			
		||||
		DIFF_OPT_SET(options, FULL_INDEX);
 | 
			
		||||
	else if (!strcmp(arg, "--binary")) {
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_PATCH;
 | 
			
		||||
		DIFF_OPT_SET(options, BINARY);
 | 
			
		||||
	}
 | 
			
		||||
	else if (!strcmp(arg, "-a") || !strcmp(arg, "--text"))
 | 
			
		||||
		DIFF_OPT_SET(options, TEXT);
 | 
			
		||||
	else if (!strcmp(arg, "--name-only"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_NAME;
 | 
			
		||||
	else if (!strcmp(arg, "--name-status"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_NAME_STATUS;
 | 
			
		||||
	else if (!strcmp(arg, "-R"))
 | 
			
		||||
		DIFF_OPT_SET(options, REVERSE_DIFF);
 | 
			
		||||
	else if (!prefixcmp(arg, "-S"))
 | 
			
		||||
		options->pickaxe = arg + 2;
 | 
			
		||||
	else if (!strcmp(arg, "-s"))
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_NO_OUTPUT;
 | 
			
		||||
	else if (!prefixcmp(arg, "-O"))
 | 
			
		||||
		options->orderfile = arg + 2;
 | 
			
		||||
	else if (!prefixcmp(arg, "--diff-filter="))
 | 
			
		||||
		options->filter = arg + 14;
 | 
			
		||||
	else if (!strcmp(arg, "--pickaxe-all"))
 | 
			
		||||
		options->pickaxe_opts = DIFF_PICKAXE_ALL;
 | 
			
		||||
	else if (!strcmp(arg, "--pickaxe-regex"))
 | 
			
		||||
		options->pickaxe_opts = DIFF_PICKAXE_REGEX;
 | 
			
		||||
 | 
			
		||||
	/* renames options */
 | 
			
		||||
	else if (!prefixcmp(arg, "-B")) {
 | 
			
		||||
		if ((options->break_opt = diff_scoreopt_parse(arg)) == -1)
 | 
			
		||||
			return -1;
 | 
			
		||||
| 
						 | 
				
			
			@ -2276,10 +2256,62 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)
 | 
			
		|||
			return -1;
 | 
			
		||||
		options->detect_rename = DIFF_DETECT_COPY;
 | 
			
		||||
	}
 | 
			
		||||
	else if (!strcmp(arg, "--no-renames"))
 | 
			
		||||
		options->detect_rename = 0;
 | 
			
		||||
 | 
			
		||||
	/* xdiff options */
 | 
			
		||||
	else if (!strcmp(arg, "-w") || !strcmp(arg, "--ignore-all-space"))
 | 
			
		||||
		options->xdl_opts |= XDF_IGNORE_WHITESPACE;
 | 
			
		||||
	else if (!strcmp(arg, "-b") || !strcmp(arg, "--ignore-space-change"))
 | 
			
		||||
		options->xdl_opts |= XDF_IGNORE_WHITESPACE_CHANGE;
 | 
			
		||||
	else if (!strcmp(arg, "--ignore-space-at-eol"))
 | 
			
		||||
		options->xdl_opts |= XDF_IGNORE_WHITESPACE_AT_EOL;
 | 
			
		||||
 | 
			
		||||
	/* flags options */
 | 
			
		||||
	else if (!strcmp(arg, "--binary")) {
 | 
			
		||||
		options->output_format |= DIFF_FORMAT_PATCH;
 | 
			
		||||
		DIFF_OPT_SET(options, BINARY);
 | 
			
		||||
	}
 | 
			
		||||
	else if (!strcmp(arg, "--full-index"))
 | 
			
		||||
		DIFF_OPT_SET(options, FULL_INDEX);
 | 
			
		||||
	else if (!strcmp(arg, "-a") || !strcmp(arg, "--text"))
 | 
			
		||||
		DIFF_OPT_SET(options, TEXT);
 | 
			
		||||
	else if (!strcmp(arg, "-R"))
 | 
			
		||||
		DIFF_OPT_SET(options, REVERSE_DIFF);
 | 
			
		||||
	else if (!strcmp(arg, "--find-copies-harder"))
 | 
			
		||||
		DIFF_OPT_SET(options, FIND_COPIES_HARDER);
 | 
			
		||||
	else if (!strcmp(arg, "--follow"))
 | 
			
		||||
		DIFF_OPT_SET(options, FOLLOW_RENAMES);
 | 
			
		||||
	else if (!strcmp(arg, "--color"))
 | 
			
		||||
		DIFF_OPT_SET(options, COLOR_DIFF);
 | 
			
		||||
	else if (!strcmp(arg, "--no-color"))
 | 
			
		||||
		DIFF_OPT_CLR(options, COLOR_DIFF);
 | 
			
		||||
	else if (!strcmp(arg, "--color-words"))
 | 
			
		||||
		options->flags |= DIFF_OPT_COLOR_DIFF | DIFF_OPT_COLOR_DIFF_WORDS;
 | 
			
		||||
	else if (!strcmp(arg, "--exit-code"))
 | 
			
		||||
		DIFF_OPT_SET(options, EXIT_WITH_STATUS);
 | 
			
		||||
	else if (!strcmp(arg, "--quiet"))
 | 
			
		||||
		DIFF_OPT_SET(options, QUIET);
 | 
			
		||||
	else if (!strcmp(arg, "--ext-diff"))
 | 
			
		||||
		DIFF_OPT_SET(options, ALLOW_EXTERNAL);
 | 
			
		||||
	else if (!strcmp(arg, "--no-ext-diff"))
 | 
			
		||||
		DIFF_OPT_CLR(options, ALLOW_EXTERNAL);
 | 
			
		||||
 | 
			
		||||
	/* misc options */
 | 
			
		||||
	else if (!strcmp(arg, "-z"))
 | 
			
		||||
		options->line_termination = 0;
 | 
			
		||||
	else if (!prefixcmp(arg, "-l"))
 | 
			
		||||
		options->rename_limit = strtoul(arg+2, NULL, 10);
 | 
			
		||||
	else if (!prefixcmp(arg, "-S"))
 | 
			
		||||
		options->pickaxe = arg + 2;
 | 
			
		||||
	else if (!strcmp(arg, "--pickaxe-all"))
 | 
			
		||||
		options->pickaxe_opts = DIFF_PICKAXE_ALL;
 | 
			
		||||
	else if (!strcmp(arg, "--pickaxe-regex"))
 | 
			
		||||
		options->pickaxe_opts = DIFF_PICKAXE_REGEX;
 | 
			
		||||
	else if (!prefixcmp(arg, "-O"))
 | 
			
		||||
		options->orderfile = arg + 2;
 | 
			
		||||
	else if (!prefixcmp(arg, "--diff-filter="))
 | 
			
		||||
		options->filter = arg + 14;
 | 
			
		||||
	else if (!strcmp(arg, "--abbrev"))
 | 
			
		||||
		options->abbrev = DEFAULT_ABBREV;
 | 
			
		||||
	else if (!prefixcmp(arg, "--abbrev=")) {
 | 
			
		||||
| 
						 | 
				
			
			@ -2289,28 +2321,6 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)
 | 
			
		|||
		else if (40 < options->abbrev)
 | 
			
		||||
			options->abbrev = 40;
 | 
			
		||||
	}
 | 
			
		||||
	else if (!strcmp(arg, "--color"))
 | 
			
		||||
		DIFF_OPT_SET(options, COLOR_DIFF);
 | 
			
		||||
	else if (!strcmp(arg, "--no-color"))
 | 
			
		||||
		DIFF_OPT_CLR(options, COLOR_DIFF);
 | 
			
		||||
	else if (!strcmp(arg, "-w") || !strcmp(arg, "--ignore-all-space"))
 | 
			
		||||
		options->xdl_opts |= XDF_IGNORE_WHITESPACE;
 | 
			
		||||
	else if (!strcmp(arg, "-b") || !strcmp(arg, "--ignore-space-change"))
 | 
			
		||||
		options->xdl_opts |= XDF_IGNORE_WHITESPACE_CHANGE;
 | 
			
		||||
	else if (!strcmp(arg, "--ignore-space-at-eol"))
 | 
			
		||||
		options->xdl_opts |= XDF_IGNORE_WHITESPACE_AT_EOL;
 | 
			
		||||
	else if (!strcmp(arg, "--color-words"))
 | 
			
		||||
		options->flags |= DIFF_OPT_COLOR_DIFF | DIFF_OPT_COLOR_DIFF_WORDS;
 | 
			
		||||
	else if (!strcmp(arg, "--no-renames"))
 | 
			
		||||
		options->detect_rename = 0;
 | 
			
		||||
	else if (!strcmp(arg, "--exit-code"))
 | 
			
		||||
		DIFF_OPT_SET(options, EXIT_WITH_STATUS);
 | 
			
		||||
	else if (!strcmp(arg, "--quiet"))
 | 
			
		||||
		DIFF_OPT_SET(options, QUIET);
 | 
			
		||||
	else if (!strcmp(arg, "--ext-diff"))
 | 
			
		||||
		DIFF_OPT_SET(options, ALLOW_EXTERNAL);
 | 
			
		||||
	else if (!strcmp(arg, "--no-ext-diff"))
 | 
			
		||||
		DIFF_OPT_CLR(options, ALLOW_EXTERNAL);
 | 
			
		||||
	else
 | 
			
		||||
		return 0;
 | 
			
		||||
	return 1;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue