Browse Source

clone: the given repository dir should be relative to $PWD

the repository argument for git-clone should be relative to $PWD
instead of the given target directory.  The old behavior gave us
surprising success and you need a few minute to know why it worked.

GIT_DIR is already exported so no need to cd into $D. And this makes
$PWD for git-fetch-pack, which is the actual command to take the given
repository dir, the same as git-clone.

Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Yasushi SHOJI 18 years ago committed by Junio C Hamano
parent
commit
ced78b3907
  1. 2
      git-clone.sh
  2. 6
      t/t5600-clone-fail-cleanup.sh

2
git-clone.sh

@ -312,7 +312,7 @@ yes,yes) @@ -312,7 +312,7 @@ yes,yes)
fi
;;
*)
cd "$D" && case "$upload_pack" in
case "$upload_pack" in
'') git-fetch-pack --all -k $quiet "$repo" ;;
*) git-fetch-pack --all -k $quiet "$upload_pack" "$repo" ;;
esac >"$GIT_DIR/CLONE_HEAD" || {

6
t/t5600-clone-fail-cleanup.sh

@ -25,6 +25,12 @@ test_create_repo foo @@ -25,6 +25,12 @@ test_create_repo foo
# clone doesn't like it if there is no HEAD. Is that a bug?
(cd foo && touch file && git add file && git commit -m 'add file' >/dev/null 2>&1)

# source repository given to git-clone should be relative to the
# current path not to the target dir
test_expect_failure \
'clone of non-existent (relative to $PWD) source should fail' \
'git-clone ../foo baz'

test_expect_success \
'clone should work now that source exists' \
'git-clone foo bar'

Loading…
Cancel
Save