Browse Source

Bisect: convert revs given to good and bad to commits

Without this the rev could be (e.g.) a tag and then the condition to end the
bisect might fail and you have to check the already known to be bad revision
once more.

Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Uwe Kleine-König 18 years ago committed by Junio C Hamano
parent
commit
cc65343a84
  1. 4
      git-bisect.sh

4
git-bisect.sh

@ -85,7 +85,7 @@ bisect_bad() { @@ -85,7 +85,7 @@ bisect_bad() {
0)
rev=$(git-rev-parse --verify HEAD) ;;
1)
rev=$(git-rev-parse --verify "$1") ;;
rev=$(git-rev-parse --verify "$1^{commit}") ;;
*)
usage ;;
esac || exit
@ -104,7 +104,7 @@ bisect_good() { @@ -104,7 +104,7 @@ bisect_good() {
esac
for rev in $revs
do
rev=$(git-rev-parse --verify "$rev") || exit
rev=$(git-rev-parse --verify "$rev^{commit}") || exit
echo "$rev" >"$GIT_DIR/refs/bisect/good-$rev"
echo "# good: "$(git-show-branch $rev) >>"$GIT_DIR/BISECT_LOG"
echo "git-bisect good $rev" >>"$GIT_DIR/BISECT_LOG"

Loading…
Cancel
Save