test-hashmap: use xsnprintf rather than snprintf
In general, using a bare snprintf can truncate the resulting buffer, leading to confusing results. In this case we know that our buffer is sized large enough to accommodate our loop, so there's no bug. However, we should use xsnprintf() to document (and check) that assumption, and to model good practice to people reading the code. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>maint
parent
b6c4380d6e
commit
cbadf0ee37
|
@ -87,7 +87,7 @@ static void perf_hashmap(unsigned int method, unsigned int rounds)
|
|||
ALLOC_ARRAY(entries, TEST_SIZE);
|
||||
ALLOC_ARRAY(hashes, TEST_SIZE);
|
||||
for (i = 0; i < TEST_SIZE; i++) {
|
||||
snprintf(buf, sizeof(buf), "%i", i);
|
||||
xsnprintf(buf, sizeof(buf), "%i", i);
|
||||
entries[i] = alloc_test_entry(0, buf, strlen(buf), "", 0);
|
||||
hashes[i] = hash(method, i, entries[i]->key);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue