Browse Source

pull: fix cli and config option parsing order

pull parses first the cli options and then the config option.
The expected behavior is the other way around, so that config
options can not override the cli ones.

This patch changes the parsing order so config options are
parsed first.

Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Nicolas Morey-Chaisemartin 7 years ago committed by Junio C Hamano
parent
commit
cad0c6928e
  1. 4
      builtin/pull.c

4
builtin/pull.c

@ -815,6 +815,8 @@ int cmd_pull(int argc, const char **argv, const char *prefix) @@ -815,6 +815,8 @@ int cmd_pull(int argc, const char **argv, const char *prefix)
if (!getenv("GIT_REFLOG_ACTION"))
set_reflog_message(argc, argv);

git_config(git_pull_config, NULL);

argc = parse_options(argc, argv, prefix, pull_options, pull_usage, 0);

parse_repo_refspecs(argc, argv, &repo, &refspecs);
@ -825,8 +827,6 @@ int cmd_pull(int argc, const char **argv, const char *prefix) @@ -825,8 +827,6 @@ int cmd_pull(int argc, const char **argv, const char *prefix)
if (opt_rebase < 0)
opt_rebase = config_get_rebase();

git_config(git_pull_config, NULL);

if (read_cache_unmerged())
die_resolve_conflict("pull");


Loading…
Cancel
Save