kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

reftable/writer: fix memory leak when `padded_write()` fails 

In reftable/writer.c:padded_write(), if w->writer failed, zeroed
allocated in `reftable_calloc` will leak. w->writer could be
`reftable_write_data` in reftable/stack.c, and could fail due to
some write error. Simply add reftable_free(zeroed) will solve this
problem.

Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Lidong Yan 2025-05-12 12:49:03 +00:00 committed by Junio C Hamano
parent d50a5e8939
commit c8e752eaef
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
reftable/writer.c
View File

@ -57,8 +57,10 @@ static int padded_write(struct reftable_writer *w, uint8_t *data, size_t len,
return -1;

n = w->write(w->write_arg, zeroed, w->pending_padding);
if (n < 0)
if (n < 0) {
reftable_free(zeroed);
return n;
}

w->pending_padding = 0;
reftable_free(zeroed);