t/test-lib.sh: minor readability improvements

Apply parameter expansion. Also use here document to save
test results instead of appending each line with ">>".

Signed-off-by: Mathias Lafeldt <misfire@debugon.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

t/test-lib.sh

@@ -575,7 +575,7 @@ test_external () {
 test_external_without_stderr () {
 	# The temporary file has no (and must have no) security
 	# implications.
-	tmp="$TMPDIR"; if [ -z "$tmp" ]; then tmp=/tmp; fi
+	tmp=${TMPDIR:-/tmp}
 	stderr="$tmp/git-external-stderr.$$.tmp"
 	test_external "$@" 4> "$stderr"
 	[ -f "$stderr" ] || error "Internal error: $stderr disappeared."
@@ -801,12 +801,14 @@ test_done () {
 		mkdir -p "$test_results_dir"
 		test_results_path="$test_results_dir/${0%.sh}-$$.counts"
 
-		echo "total $test_count" >> $test_results_path
+		cat >>"$test_results_path" <<-EOF
-		echo "success $test_success" >> $test_results_path
+		total $test_count
-		echo "fixed $test_fixed" >> $test_results_path
+		success $test_success
-		echo "broken $test_broken" >> $test_results_path
+		fixed $test_fixed
-		echo "failed $test_failure" >> $test_results_path
+		broken $test_broken
-		echo "" >> $test_results_path
+		failed $test_failure
+
+		EOF
 	fi
 
 	if test "$test_fixed" != 0