Browse Source

Merge branch 'jk/type-from-string-gently' into maint

"git cat-file bl $blob" failed to barf even though there is no
object type that is "bl".

* jk/type-from-string-gently:
  type_from_string_gently: make sure length matches
maint
Junio C Hamano 10 years ago
parent
commit
c1c4a878bb
  1. 3
      object.c
  2. 8
      t/t1007-hash-object.sh

3
object.c

@ -41,7 +41,8 @@ int type_from_string_gently(const char *str, ssize_t len, int gentle) @@ -41,7 +41,8 @@ int type_from_string_gently(const char *str, ssize_t len, int gentle)
len = strlen(str);

for (i = 1; i < ARRAY_SIZE(object_type_strings); i++)
if (!strncmp(str, object_type_strings[i], len))
if (!strncmp(str, object_type_strings[i], len) &&
object_type_strings[i][len] == '\0')
return i;

if (gentle)

8
t/t1007-hash-object.sh

@ -201,4 +201,12 @@ test_expect_success 'corrupt tag' ' @@ -201,4 +201,12 @@ test_expect_success 'corrupt tag' '
test_must_fail git hash-object -t tag --stdin </dev/null
'

test_expect_success 'hash-object complains about bogus type name' '
test_must_fail git hash-object -t bogus --stdin </dev/null
'

test_expect_success 'hash-object complains about truncated type name' '
test_must_fail git hash-object -t bl --stdin </dev/null
'

test_done

Loading…
Cancel
Save