Browse Source

Merge branch 'mh/transport-capabilities'

The transport-helper did not give transport options such as
verbosity, progress, cloning, etc. to import and export based
helpers, like it did for fetch and push based helpers, robbing them
the chance to honor the wish of the end-users better.

* mh/transport-capabilities:
  transport-helper: ask the helper to set the same options for import as for fetch
  transport-helper: ask the helper to set progress and verbosity options after asking for its capabilities
maint
Junio C Hamano 10 years ago
parent
commit
be94b339b6
  1. 25
      transport-helper.c

25
transport-helper.c

@ -97,6 +97,8 @@ static void do_take_over(struct transport *transport) @@ -97,6 +97,8 @@ static void do_take_over(struct transport *transport)
free(data);
}

static void standard_options(struct transport *t);

static struct child_process *get_helper(struct transport *transport)
{
struct helper_data *data = transport->data;
@ -211,6 +213,7 @@ static struct child_process *get_helper(struct transport *transport) @@ -211,6 +213,7 @@ static struct child_process *get_helper(struct transport *transport)
strbuf_release(&buf);
if (debug)
fprintf(stderr, "Debug: Capabilities complete.\n");
standard_options(transport);
return data->helper;
}

@ -338,17 +341,6 @@ static int fetch_with_fetch(struct transport *transport, @@ -338,17 +341,6 @@ static int fetch_with_fetch(struct transport *transport,
int i;
struct strbuf buf = STRBUF_INIT;

standard_options(transport);
if (data->check_connectivity &&
data->transport_options.check_self_contained_and_connected)
set_helper_option(transport, "check-connectivity", "true");

if (transport->cloning)
set_helper_option(transport, "cloning", "true");

if (data->transport_options.update_shallow)
set_helper_option(transport, "update-shallow", "true");

for (i = 0; i < nr_heads; i++) {
const struct ref *posn = to_fetch[i];
if (posn->status & REF_STATUS_UPTODATE)
@ -622,6 +614,16 @@ static int fetch(struct transport *transport, @@ -622,6 +614,16 @@ static int fetch(struct transport *transport,
if (!count)
return 0;

if (data->check_connectivity &&
data->transport_options.check_self_contained_and_connected)
set_helper_option(transport, "check-connectivity", "true");

if (transport->cloning)
set_helper_option(transport, "cloning", "true");

if (data->transport_options.update_shallow)
set_helper_option(transport, "update-shallow", "true");

if (data->fetch)
return fetch_with_fetch(transport, nr_heads, to_fetch);

@ -826,7 +828,6 @@ static int push_refs_with_push(struct transport *transport, @@ -826,7 +828,6 @@ static int push_refs_with_push(struct transport *transport,
return 0;
}

standard_options(transport);
for_each_string_list_item(cas_option, &cas_options)
set_helper_option(transport, "cas", cas_option->string);


Loading…
Cancel
Save