Browse Source

tests: mark tests as passing with SANITIZE=leak

When the "ab/various-leak-fixes" topic was merged in [1] only t6021
would fail if the tests were run in the
"GIT_TEST_PASSING_SANITIZE_LEAK=check" mode, i.e. to check whether we
marked all leak-free tests with "TEST_PASSES_SANITIZE_LEAK=true".

Since then we've had various tests starting to pass under
SANITIZE=leak. Let's mark those as passing, this is when they started
to pass, narrowed down with "git bisect":

- t5317-pack-objects-filter-objects.sh: In
  faebba436e (list-objects-filter: plug pattern_list leak, 2022-12-01).

- t3210-pack-refs.sh, t5613-info-alternate.sh,
  t7403-submodule-sync.sh: In 189e97bc4b (diff: remove parseopts member
  from struct diff_options, 2022-12-01).

- t1408-packed-refs.sh: In ab91f6b7c4 (Merge branch
  'rs/diff-parseopts', 2022-12-19).

- t0023-crlf-am.sh, t4152-am-subjects.sh, t4254-am-corrupt.sh,
  t4256-am-format-flowed.sh, t4257-am-interactive.sh,
  t5403-post-checkout-hook.sh: In a658e881c1 (am: don't pass strvec to
  apply_parse_options(), 2022-12-13)

- t1301-shared-repo.sh, t1302-repo-version.sh: In b07a819c05 (reflog:
  clear leftovers in reflog_expiry_cleanup(), 2022-12-13).

- t1304-default-acl.sh, t1410-reflog.sh,
  t5330-no-lazy-fetch-with-commit-graph.sh, t5502-quickfetch.sh,
  t5604-clone-reference.sh, t6014-rev-list-all.sh,
  t7701-repack-unpack-unreachable.sh: In b0c61be320 (Merge branch
  'rs/reflog-expiry-cleanup', 2022-12-26)

- t3800-mktag.sh, t5302-pack-index.sh, t5306-pack-nobase.sh,
  t5573-pull-verify-signatures.sh, t7612-merge-verify-signatures.sh: In
  69bbbe484b (hash-object: use fsck for object checks, 2023-01-18).

- t1451-fsck-buffer.sh: In 8e4309038f (fsck: do not assume
  NUL-termination of buffers, 2023-01-19).

- t6501-freshen-objects.sh: In abf2bb895b (Merge branch
  'jk/hash-object-fsck', 2023-01-30)

1. 9ea1378d04 (Merge branch 'ab/various-leak-fixes', 2022-12-14)

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Ævar Arnfjörð Bjarmason 2 years ago committed by Junio C Hamano
parent
commit
b2e5d75d17
  1. 1
      t/t0023-crlf-am.sh
  2. 1
      t/t1301-shared-repo.sh
  3. 1
      t/t1302-repo-version.sh
  4. 1
      t/t1304-default-acl.sh
  5. 1
      t/t1408-packed-refs.sh
  6. 1
      t/t1410-reflog.sh
  7. 2
      t/t1451-fsck-buffer.sh
  8. 1
      t/t3210-pack-refs.sh
  9. 1
      t/t3800-mktag.sh
  10. 2
      t/t4152-am-subjects.sh
  11. 2
      t/t4254-am-corrupt.sh
  12. 1
      t/t4256-am-format-flowed.sh
  13. 2
      t/t4257-am-interactive.sh
  14. 2
      t/t5302-pack-index.sh
  15. 2
      t/t5306-pack-nobase.sh
  16. 1
      t/t5317-pack-objects-filter-objects.sh
  17. 1
      t/t5330-no-lazy-fetch-with-commit-graph.sh
  18. 1
      t/t5403-post-checkout-hook.sh
  19. 1
      t/t5502-quickfetch.sh
  20. 2
      t/t5573-pull-verify-signatures.sh
  21. 1
      t/t5604-clone-reference.sh
  22. 2
      t/t5613-info-alternate.sh
  23. 1
      t/t6014-rev-list-all.sh
  24. 1
      t/t6021-rev-list-exclude-hidden.sh
  25. 1
      t/t6501-freshen-objects.sh
  26. 1
      t/t7403-submodule-sync.sh
  27. 1
      t/t7612-merge-verify-signatures.sh
  28. 1
      t/t7701-repack-unpack-unreachable.sh

1
t/t0023-crlf-am.sh

@ -2,6 +2,7 @@ @@ -2,6 +2,7 @@

test_description='Test am with auto.crlf'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

cat >patchfile <<\EOF

1
t/t1301-shared-repo.sh

@ -9,6 +9,7 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main @@ -9,6 +9,7 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_CREATE_REPO_NO_TEMPLATE=1
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

# Remove a default ACL from the test dir if possible.

1
t/t1302-repo-version.sh

@ -5,6 +5,7 @@ @@ -5,6 +5,7 @@

test_description='Test repository version check'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success 'setup' '

1
t/t1304-default-acl.sh

@ -9,6 +9,7 @@ test_description='Test repository with default ACL' @@ -9,6 +9,7 @@ test_description='Test repository with default ACL'
# => this must come before . ./test-lib.sh
umask 077

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

# We need an arbitrary other user give permission to using ACLs. root

1
t/t1408-packed-refs.sh

@ -5,6 +5,7 @@ test_description='packed-refs entries are covered by loose refs' @@ -5,6 +5,7 @@ test_description='packed-refs entries are covered by loose refs'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success setup '

1
t/t1410-reflog.sh

@ -7,6 +7,7 @@ test_description='Test prune and reflog expiration' @@ -7,6 +7,7 @@ test_description='Test prune and reflog expiration'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

check_have () {

2
t/t1451-fsck-buffer.sh

@ -14,6 +14,8 @@ so. @@ -14,6 +14,8 @@ so.
These tests _might_ catch such overruns in normal use, but should be run with
ASan or valgrind for more confidence.
'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

# the general idea for tags and commits is to build up the "base" file

1
t/t3210-pack-refs.sh

@ -12,6 +12,7 @@ semantic is still the same. @@ -12,6 +12,7 @@ semantic is still the same.
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success 'enable reflogs' '

1
t/t3800-mktag.sh

@ -4,6 +4,7 @@ @@ -4,6 +4,7 @@

test_description='git mktag: tag object verify test'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

###########################################################

2
t/t4152-am-subjects.sh

@ -1,6 +1,8 @@ @@ -1,6 +1,8 @@
#!/bin/sh

test_description='test subject preservation with format-patch | am'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

make_patches() {

2
t/t4254-am-corrupt.sh

@ -1,6 +1,8 @@ @@ -1,6 +1,8 @@
#!/bin/sh

test_description='git am with corrupt input'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

make_mbox_with_nul () {

1
t/t4256-am-format-flowed.sh

@ -2,6 +2,7 @@ @@ -2,6 +2,7 @@

test_description='test format=flowed support of git am'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success 'setup' '

2
t/t4257-am-interactive.sh

@ -1,6 +1,8 @@ @@ -1,6 +1,8 @@
#!/bin/sh

test_description='am --interactive tests'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success 'set up patches to apply' '

2
t/t5302-pack-index.sh

@ -4,6 +4,8 @@ @@ -4,6 +4,8 @@
#

test_description='pack index with 64-bit offsets and object CRC'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success 'setup' '

2
t/t5306-pack-nobase.sh

@ -6,6 +6,8 @@ @@ -6,6 +6,8 @@
test_description='git-pack-object with missing base

'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

# Create A-B chain

1
t/t5317-pack-objects-filter-objects.sh

@ -5,6 +5,7 @@ test_description='git pack-objects using object filtering' @@ -5,6 +5,7 @@ test_description='git pack-objects using object filtering'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

# Test blob:none filter.

1
t/t5330-no-lazy-fetch-with-commit-graph.sh

@ -2,6 +2,7 @@ @@ -2,6 +2,7 @@

test_description='test for no lazy fetch with the commit-graph'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success 'setup: prepare a repository with a commit' '

1
t/t5403-post-checkout-hook.sh

@ -7,6 +7,7 @@ test_description='Test the post-checkout hook.' @@ -7,6 +7,7 @@ test_description='Test the post-checkout hook.'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success setup '

1
t/t5502-quickfetch.sh

@ -5,6 +5,7 @@ test_description='test quickfetch from local' @@ -5,6 +5,7 @@ test_description='test quickfetch from local'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success setup '

2
t/t5573-pull-verify-signatures.sh

@ -1,6 +1,8 @@ @@ -1,6 +1,8 @@
#!/bin/sh

test_description='pull signature verification tests'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh
. "$TEST_DIRECTORY/lib-gpg.sh"


1
t/t5604-clone-reference.sh

@ -7,6 +7,7 @@ test_description='test clone --reference' @@ -7,6 +7,7 @@ test_description='test clone --reference'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

base_dir=$(pwd)

2
t/t5613-info-alternate.sh

@ -4,6 +4,8 @@ @@ -4,6 +4,8 @@
#

test_description='test transitive info/alternate entries'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success 'preparing first repository' '

1
t/t6014-rev-list-all.sh

@ -2,6 +2,7 @@ @@ -2,6 +2,7 @@

test_description='--all includes detached HEADs'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh



1
t/t6021-rev-list-exclude-hidden.sh

@ -2,6 +2,7 @@ @@ -2,6 +2,7 @@

test_description='git rev-list --exclude-hidden test'

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success 'setup' '

1
t/t6501-freshen-objects.sh

@ -28,6 +28,7 @@ test_description='check pruning of dependent objects' @@ -28,6 +28,7 @@ test_description='check pruning of dependent objects'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

# We care about reachability, so we do not want to use

1
t/t7403-submodule-sync.sh

@ -11,6 +11,7 @@ These tests exercise the "git submodule sync" subcommand. @@ -11,6 +11,7 @@ These tests exercise the "git submodule sync" subcommand.
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

test_expect_success setup '

1
t/t7612-merge-verify-signatures.sh

@ -4,6 +4,7 @@ test_description='merge signature verification tests' @@ -4,6 +4,7 @@ test_description='merge signature verification tests'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh
. "$TEST_DIRECTORY/lib-gpg.sh"


1
t/t7701-repack-unpack-unreachable.sh

@ -5,6 +5,7 @@ test_description='git repack works correctly' @@ -5,6 +5,7 @@ test_description='git repack works correctly'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME

TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh

fsha1=

Loading…
Cancel
Save