kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

object-file: move empty_tree struct into find_cached_object() 

The fake empty_tree struct is a static global, but the only code that
looks at it is find_cached_object(). The struct itself is a little odd,
with an invalid "oid" field that is handled specially by that function.

Since it's really just an implementation detail, let's move it to a
static within the function. That future-proofs against other code trying
to use it and seeing the weird oid value.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Jeff King 2024-11-18 04:55:11 -05:00 committed by Junio C Hamano
parent 2911f9ed1e
commit b2a95dfd63
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
object-file.c
View File

@ -325,14 +325,13 @@ static struct cached_object {
} *cached_objects;
static int cached_object_nr, cached_object_alloc;

static struct cached_object empty_tree = {
/* no oid needed; we'll look it up manually based on the_hash_algo */
.type = OBJ_TREE,
.buf = "",
};

static struct cached_object *find_cached_object(const struct object_id *oid)
{
static struct cached_object empty_tree = {
/* no oid needed; we'll look it up manually based on the_hash_algo */
.type = OBJ_TREE,
.buf = "",
};
int i;
struct cached_object *co = cached_objects;