Browse Source

ls-tree $di $dir: do not mistakenly recurse into directories

When applying two pathspecs, one of which is named as a prefix to the
other, we mistakenly recursed into the shorter one.

Noticed and fixed by David Reis.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Junio C Hamano 15 years ago
parent
commit
b294ed637d
  1. 2
      builtin/ls-tree.c
  2. 9
      t/t3100-ls-tree-restrict.sh

2
builtin/ls-tree.c

@ -52,6 +52,8 @@ static int show_recursive(const char *base, int baselen, const char *pathname) @@ -52,6 +52,8 @@ static int show_recursive(const char *base, int baselen, const char *pathname)
speclen = strlen(spec);
if (speclen <= len)
continue;
if (spec[len] && spec[len] != '/')
continue;
if (memcmp(pathname, spec, len))
continue;
return 1;

9
t/t3100-ls-tree-restrict.sh

@ -165,4 +165,13 @@ test_expect_success \ @@ -165,4 +165,13 @@ test_expect_success \
EOF
test_output'

test_expect_success \
'ls-tree with one path a prefix of the other' \
'git ls-tree $tree path2/baz path2/bazbo >current &&
make_expected <<\EOF &&
040000 tree X path2/baz
120000 blob X path2/bazbo
EOF
test_output'

test_done

Loading…
Cancel
Save