Browse Source

[PATCH] Fixed two bugs in git-cvsimport-script.

The git-cvsimport-script had a copule of small bugs that prevented me
from importing a big CVS repository.

The first was that it didn't handle removed files with a multi-digit
primary revision number.

The second was that it was asking the CVS server for "F" messages,
although they were not handled.

I also updated the documentation for that script to correspond to
actual flags.

Signed-off-by: David K?5gedal <davidk@lysator.liu.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
iso-8859-1?Q?David_K=E5gedal 20 years ago committed by Junio C Hamano
parent
commit
b092133103
  1. 9
      Documentation/git-cvsimport-script.txt
  2. 4
      git-cvsimport-script

9
Documentation/git-cvsimport-script.txt

@ -29,6 +29,10 @@ OPTIONS @@ -29,6 +29,10 @@ OPTIONS
currently, only the :local:, :ext: and :pserver: access methods
are supported.

-C <target-dir>::
The GIT repository to import to. If the directory doesn't
exist, it will be created. Default is the current directory.

-i::
Import-only: don't perform a checkout after importing. This option
ensures the working directory and cache remain untouched and will
@ -44,7 +48,7 @@ OPTIONS @@ -44,7 +48,7 @@ OPTIONS

-p <options-for-cvsps>::
Additional options for cvsps.
The options '-x' and '-A' are implicit and should not be used here.
The options '-u' and '-A' are implicit and should not be used here.

If you need to pass multiple options, separate them with a comma.

@ -57,6 +61,9 @@ OPTIONS @@ -57,6 +61,9 @@ OPTIONS
-h::
Print a short usage message and exit.

-z <fuzz>::
Pass the timestamp fuzz factor to cvsps.

OUTPUT
------
If '-v' is specified, the script reports what it is doing.

4
git-cvsimport-script

@ -190,7 +190,7 @@ sub conn { @@ -190,7 +190,7 @@ sub conn {
$self->{'socketo'}->write("Root $repo\n");

# Trial and error says that this probably is the minimum set
$self->{'socketo'}->write("Valid-responses ok error Valid-requests Mode M Mbinary E F Checked-in Created Updated Merged Removed\n");
$self->{'socketo'}->write("Valid-responses ok error Valid-requests Mode M Mbinary E Checked-in Created Updated Merged Removed\n");

$self->{'socketo'}->write("valid-requests\n");
$self->{'socketo'}->flush();
@ -702,7 +702,7 @@ while(<CVS>) { @@ -702,7 +702,7 @@ while(<CVS>) {
push(@new,[$mode, $sha, $fn]); # may be resurrected!
}
unlink($tmpname);
} elsif($state == 9 and /^\s+(.+?):\d(?:\.\d+)+->(\d(?:\.\d+)+)\(DEAD\)\s*$/) {
} elsif($state == 9 and /^\s+(.+?):\d+(?:\.\d+)+->(\d+(?:\.\d+)+)\(DEAD\)\s*$/) {
my $fn = $1;
$fn =~ s#^/+##;
push(@old,$fn);

Loading…
Cancel
Save