t0000: cover GIT_SKIP_TESTS blindspots
Currently, the tests for GIT_SKIP_TESTS do not cover the situation where we skip an entire test suite. The tests also do not cover the situation where we have GIT_SKIP_TESTS defined but the test suite does not match. Add two test cases so we cover this blindspot. Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>maint
							parent
							
								
									5fa0f5238b
								
							
						
					
					
						commit
						b05b40930e
					
				|  | @ -391,6 +391,44 @@ test_expect_success 'GIT_SKIP_TESTS sh pattern' " | ||||||
| 	) | 	) | ||||||
| " | " | ||||||
|  |  | ||||||
|  | test_expect_success 'GIT_SKIP_TESTS entire suite' " | ||||||
|  | 	( | ||||||
|  | 		GIT_SKIP_TESTS='git' && export GIT_SKIP_TESTS && | ||||||
|  | 		run_sub_test_lib_test git-skip-tests-entire-suite \ | ||||||
|  | 			'GIT_SKIP_TESTS entire suite' <<-\\EOF && | ||||||
|  | 		for i in 1 2 3 | ||||||
|  | 		do | ||||||
|  | 			test_expect_success \"passing test #\$i\" 'true' | ||||||
|  | 		done | ||||||
|  | 		test_done | ||||||
|  | 		EOF | ||||||
|  | 		check_sub_test_lib_test git-skip-tests-entire-suite <<-\\EOF | ||||||
|  | 		> 1..0 # SKIP skip all tests in git | ||||||
|  | 		EOF | ||||||
|  | 	) | ||||||
|  | " | ||||||
|  |  | ||||||
|  | test_expect_success 'GIT_SKIP_TESTS does not skip unmatched suite' " | ||||||
|  | 	( | ||||||
|  | 		GIT_SKIP_TESTS='notgit' && export GIT_SKIP_TESTS && | ||||||
|  | 		run_sub_test_lib_test git-skip-tests-unmatched-suite \ | ||||||
|  | 			'GIT_SKIP_TESTS does not skip unmatched suite' <<-\\EOF && | ||||||
|  | 		for i in 1 2 3 | ||||||
|  | 		do | ||||||
|  | 			test_expect_success \"passing test #\$i\" 'true' | ||||||
|  | 		done | ||||||
|  | 		test_done | ||||||
|  | 		EOF | ||||||
|  | 		check_sub_test_lib_test git-skip-tests-unmatched-suite <<-\\EOF | ||||||
|  | 		> ok 1 - passing test #1 | ||||||
|  | 		> ok 2 - passing test #2 | ||||||
|  | 		> ok 3 - passing test #3 | ||||||
|  | 		> # passed all 3 test(s) | ||||||
|  | 		> 1..3 | ||||||
|  | 		EOF | ||||||
|  | 	) | ||||||
|  | " | ||||||
|  |  | ||||||
| test_expect_success '--run basic' " | test_expect_success '--run basic' " | ||||||
| 	run_sub_test_lib_test run-basic \ | 	run_sub_test_lib_test run-basic \ | ||||||
| 		'--run basic' --run='1 3 5' <<-\\EOF && | 		'--run basic' --run='1 3 5' <<-\\EOF && | ||||||
|  |  | ||||||
		Loading…
	
		Reference in New Issue
	
	 Denton Liu
						Denton Liu