Browse Source

prefer test -h over test -L in shell scripts

Even though "-L" is POSIX, the former is more portable, and
we tend to prefer it already.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Jeff King 15 years ago committed by Junio C Hamano
parent
commit
afa0876050
  1. 2
      contrib/workdir/git-new-workdir
  2. 6
      t/t9100-git-svn-basic.sh
  3. 2
      t/t9131-git-svn-empty-symlink.sh

2
contrib/workdir/git-new-workdir

@ -42,7 +42,7 @@ then @@ -42,7 +42,7 @@ then
fi

# don't link to a workdir
if test -L "$git_dir/config"
if test -h "$git_dir/config"
then
die "\"$orig_git\" is a working directory only, please specify" \
"a complete repository."

6
t/t9100-git-svn-basic.sh

@ -143,7 +143,7 @@ test_expect_success "$name" ' @@ -143,7 +143,7 @@ test_expect_success "$name" '
git svn set-tree --find-copies-harder --rmdir \
${remotes_git_svn}..mybranch5 &&
svn_cmd up "$SVN_TREE" &&
test -L "$SVN_TREE"/exec.sh'
test -h "$SVN_TREE"/exec.sh'

name='new symlink is added to a file that was also just made executable'

@ -156,7 +156,7 @@ test_expect_success "$name" ' @@ -156,7 +156,7 @@ test_expect_success "$name" '
${remotes_git_svn}..mybranch5 &&
svn_cmd up "$SVN_TREE" &&
test -x "$SVN_TREE"/bar/zzz &&
test -L "$SVN_TREE"/exec-2.sh'
test -h "$SVN_TREE"/exec-2.sh'

name='modify a symlink to become a file'
test_expect_success "$name" '
@ -169,7 +169,7 @@ test_expect_success "$name" ' @@ -169,7 +169,7 @@ test_expect_success "$name" '
${remotes_git_svn}..mybranch5 &&
svn_cmd up "$SVN_TREE" &&
test -f "$SVN_TREE"/exec-2.sh &&
test ! -L "$SVN_TREE"/exec-2.sh &&
test ! -h "$SVN_TREE"/exec-2.sh &&
test_cmp help "$SVN_TREE"/exec-2.sh'

name="commit with UTF-8 message: locale: $GIT_SVN_LC_ALL"

2
t/t9131-git-svn-empty-symlink.sh

@ -88,7 +88,7 @@ test_expect_success 'enable broken symlink workaround' \ @@ -88,7 +88,7 @@ test_expect_success 'enable broken symlink workaround' \
test_expect_success '"bar" is an empty file' 'test -f x/bar && ! test -s x/bar'
test_expect_success 'get "bar" => symlink fix from svn' \
'(cd x && git svn rebase)'
test_expect_success SYMLINKS '"bar" becomes a symlink' 'test -L x/bar'
test_expect_success SYMLINKS '"bar" becomes a symlink' 'test -h x/bar'


test_expect_success 'clone using git svn' 'git svn clone -r1 "$svnrepo" y'

Loading…
Cancel
Save