kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

revision.c: remove unneeded check for NULL 

The function is called only from one place, which makes sure to have
`interesting_cache` not NULL.  Additionally the variable is a
dereferenced a few lines before unconditionally, which would have
resulted in a segmentation fault before hitting this check.

Signed-off-by: Stefan Beller <sbeller@google.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Stefan Beller 2015-06-26 12:40:19 -07:00 committed by Junio C Hamano
parent b6e8a3b540
commit ae40ebda9b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
revision.c
View File

@ -350,7 +350,7 @@ static int everybody_uninteresting(struct commit_list *orig,
list = list->next; list = list->next;
if (commit->object.flags & UNINTERESTING) if (commit->object.flags & UNINTERESTING)
continue; continue;
if (interesting_cache)
*interesting_cache = commit; *interesting_cache = commit;
return 0; return 0;
} }