kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

help: drop prepend function in favor of xstrfmt 

This function predates xstrfmt, and its functionality is a
subset. Let's just use xstrfmt.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Jeff King 2015-09-24 17:07:14 -04:00 committed by Junio C Hamano
parent a5e03bf5c6
commit acd47eec99
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
builtin/help.c
View File

@ -295,16 +295,6 @@ static int is_git_command(const char *s)
is_in_cmdlist(&other_cmds, s); is_in_cmdlist(&other_cmds, s);
} }


static const char *prepend(const char *prefix, const char *cmd)
{
size_t pre_len = strlen(prefix);
size_t cmd_len = strlen(cmd);
char *p = xmalloc(pre_len + cmd_len + 1);
memcpy(p, prefix, pre_len);
strcpy(p + pre_len, cmd);
return p;
}

static const char *cmd_to_page(const char *git_cmd) static const char *cmd_to_page(const char *git_cmd)
{ {
if (!git_cmd) if (!git_cmd)
@ -312,9 +302,9 @@ static const char *cmd_to_page(const char *git_cmd)
else if (starts_with(git_cmd, "git")) else if (starts_with(git_cmd, "git"))
return git_cmd; return git_cmd;
else if (is_git_command(git_cmd)) else if (is_git_command(git_cmd))
return prepend("git-", git_cmd); return xstrfmt("git-%s", git_cmd);
else else
return prepend("git", git_cmd); return xstrfmt("git%s", git_cmd);
} }


static void setup_man_path(void) static void setup_man_path(void)