Merge branch 'rj/xdiff-prepare-plug-leak-on-error-codepath'
A small memory leak in an error codepath has been plugged in xdiff code. * rj/xdiff-prepare-plug-leak-on-error-codepath: xdiff/xprepare: fix a memory leak xdiff/xprepare: use the XDF_DIFF_ALG() macro to access flag bitsmaint
						commit
						aa3a2c2af6
					
				|  | @ -301,10 +301,11 @@ int xdl_prepare_env(mmfile_t *mf1, mmfile_t *mf2, xpparam_t const *xpp, | ||||||
|  |  | ||||||
| 		xdl_free_ctx(&xe->xdf2); | 		xdl_free_ctx(&xe->xdf2); | ||||||
| 		xdl_free_ctx(&xe->xdf1); | 		xdl_free_ctx(&xe->xdf1); | ||||||
|  | 		xdl_free_classifier(&cf); | ||||||
| 		return -1; | 		return -1; | ||||||
| 	} | 	} | ||||||
|  |  | ||||||
| 	if (!(xpp->flags & XDF_HISTOGRAM_DIFF)) | 	if (XDF_DIFF_ALG(xpp->flags) != XDF_HISTOGRAM_DIFF) | ||||||
| 		xdl_free_classifier(&cf); | 		xdl_free_classifier(&cf); | ||||||
|  |  | ||||||
| 	return 0; | 	return 0; | ||||||
|  |  | ||||||
		Loading…
	
		Reference in New Issue
	
	 Junio C Hamano
						Junio C Hamano