Browse Source

http: drop the check for an empty proxy password before approving

credential_approve() already checks for a non-empty password before
saving, so there's no need to do the extra check here.

Signed-off-by: John Szakmeister <john@szakmeister.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
John Szakmeister 4 years ago committed by Junio C Hamano
parent
commit
a4a4439fdf
  1. 3
      http.c

3
http.c

@ -1635,8 +1635,7 @@ static int handle_curl_result(struct slot_results *results) @@ -1635,8 +1635,7 @@ static int handle_curl_result(struct slot_results *results)

if (results->curl_result == CURLE_OK) {
credential_approve(&http_auth);
if (proxy_auth.password)
credential_approve(&proxy_auth);
credential_approve(&proxy_auth);
credential_approve(&cert_auth);
return HTTP_OK;
} else if (results->curl_result == CURLE_SSL_CERTPROBLEM) {

Loading…
Cancel
Save