Browse Source

[PATCH] Fix math thinko in similarity estimator.

The math to reject delta that is too big was confused.

Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
maint
Junio C Hamano 20 years ago committed by Linus Torvalds
parent
commit
a00d7d106a
  1. 2
      diffcore-rename.c

2
diffcore-rename.c

@ -163,7 +163,7 @@ static int estimate_similarity(struct diff_filespec *src, @@ -163,7 +163,7 @@ static int estimate_similarity(struct diff_filespec *src,
/* A delta that has a lot of literal additions would have
* big delta_size no matter what else it does.
*/
if (minimum_score < MAX_SCORE * delta_size / base_size)
if (base_size * (MAX_SCORE-minimum_score) < delta_size * MAX_SCORE)
return 0;

/* Estimate the edit size by interpreting delta. */

Loading…
Cancel
Save