kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

builtin/update-server-info: remove unnecessary if statement 

Since we already teach the `repo_config()` in f29f1990 (config:
teach repo_config to allow `repo` to be NULL, 2025-03-08) to allow
`repo` to be NULL, no need to check if `repo` is NULL before calling
`repo_config()`.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Usman Akinyemi 2025-04-08 01:28:41 +05:30 committed by Junio C Hamano
parent 66b90d9bad
commit 9ec327d922
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/update-server-info.c
View File

@ -20,8 +20,8 @@ int cmd_update_server_info(int argc,
OPT_END()
};

if (repo)
repo_config(repo, git_default_config, NULL);
repo_config(repo, git_default_config, NULL);

argc = parse_options(argc, argv, prefix, options,
update_server_info_usage, 0);
if (argc > 0)

7
t/t1517-outside-repo.sh
View File

@ -107,4 +107,11 @@ test_expect_success LIBCURL 'remote-http outside repository' '
test_grep "^error: remote-curl" actual
'

test_expect_success 'update-server-info does not crash with -h' '
test_expect_code 129 git update-server-info -h >usage &&
test_grep "[Uu]sage: git update-server-info " usage &&
test_expect_code 129 nongit git update-server-info -h >usage &&
test_grep "[Uu]sage: git update-server-info " usage
'

test_done