Browse Source

Merge branch 'jc/boundary' into next

* jc/boundary:
  rev-list --boundary: show boundary commits even when limited otherwise.
  Makefile fixups.
  gitk: Fix bug caused by missing commitlisted elements
maint
Junio C Hamano 19 years ago
parent
commit
9893e3eb92
  1. 2
      Makefile
  2. 5
      gitk
  3. 10
      http-push.c
  4. 4
      rev-list.c
  5. 29
      revision.c
  6. 3
      revision.h
  7. 2
      t/Makefile

2
Makefile

@ -656,7 +656,7 @@ rpm: dist
clean: clean:
rm -f *.o mozilla-sha1/*.o arm/*.o ppc/*.o compat/*.o xdiff/*.o \ rm -f *.o mozilla-sha1/*.o arm/*.o ppc/*.o compat/*.o xdiff/*.o \
$(LIB_FILE) $(XDIFF_LIB) $(LIB_FILE) $(XDIFF_LIB)
rm -f $(ALL_PROGRAMS) git$X rm -f $(ALL_PROGRAMS) $(BUILT_INS) git$X
rm -f test-date$X test-delta$X test-gsimm$X rm -f test-date$X test-delta$X test-gsimm$X
rm -f *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags rm -f *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags
rm -rf $(GIT_TARNAME) rm -rf $(GIT_TARNAME)

5
gitk

@ -1116,11 +1116,12 @@ proc layoutrows {row endrow last} {


proc addextraid {id row} { proc addextraid {id row} {
global displayorder commitrow commitinfo global displayorder commitrow commitinfo
global commitidx global commitidx commitlisted
global parentlist childlist children global parentlist childlist children


incr commitidx incr commitidx
lappend displayorder $id lappend displayorder $id
lappend commitlisted 0
lappend parentlist {} lappend parentlist {}
set commitrow($id) $row set commitrow($id) $row
readcommit $id readcommit $id
@ -1500,7 +1501,7 @@ proc drawcmittext {id row col rmx} {
proc drawcmitrow {row} { proc drawcmitrow {row} {
global displayorder rowidlist global displayorder rowidlist
global idrowranges idrangedrawn iddrawn global idrowranges idrangedrawn iddrawn
global commitinfo commitlisted parentlist numcommits global commitinfo parentlist numcommits


if {$row >= $numcommits} return if {$row >= $numcommits} return
foreach id [lindex $rowidlist $row] { foreach id [lindex $rowidlist $row] {

10
http-push.c

@ -60,12 +60,12 @@ enum XML_Status {
#define LOCK_TIME 600 #define LOCK_TIME 600
#define LOCK_REFRESH 30 #define LOCK_REFRESH 30


/* bits #0-6 in revision.h */ /* bits #0-15 in revision.h */


#define LOCAL (1u << 7) #define LOCAL (1u<<16)
#define REMOTE (1u << 8) #define REMOTE (1u<<17)
#define FETCHING (1u << 9) #define FETCHING (1u<<18)
#define PUSHING (1u << 10) #define PUSHING (1u<<19)


/* We allow "recursive" symbolic refs. Only within reason, though */ /* We allow "recursive" symbolic refs. Only within reason, though */
#define MAXDEPTH 5 #define MAXDEPTH 5

4
rev-list.c

@ -8,9 +8,9 @@
#include "diff.h" #include "diff.h"
#include "revision.h" #include "revision.h"


/* bits #0-6 in revision.h */ /* bits #0-15 in revision.h */


#define COUNTED (1u<<7) #define COUNTED (1u<<16)


static const char rev_list_usage[] = static const char rev_list_usage[] =
"git-rev-list [OPTION] <commit-id>... [ -- paths... ]\n" "git-rev-list [OPTION] <commit-id>... [ -- paths... ]\n"

29
revision.c

@ -856,6 +856,17 @@ static void rewrite_parents(struct rev_info *revs, struct commit *commit)
} }
} }


static void mark_boundary_to_show(struct commit *commit)
{
struct commit_list *p = commit->parents;
while (p) {
commit = p->item;
p = p->next;
if (commit->object.flags & BOUNDARY)
commit->object.flags |= BOUNDARY_SHOW;
}
}

struct commit *get_revision(struct rev_info *revs) struct commit *get_revision(struct rev_info *revs)
{ {
struct commit_list *list = revs->commits; struct commit_list *list = revs->commits;
@ -893,8 +904,20 @@ struct commit *get_revision(struct rev_info *revs)
} }
if (commit->object.flags & SHOWN) if (commit->object.flags & SHOWN)
continue; continue;
if (!(commit->object.flags & BOUNDARY) &&
(commit->object.flags & UNINTERESTING)) /* We want to show boundary commits only when their
* children are shown. When path-limiter is in effect,
* rewrite_parents() drops some commits from getting shown,
* and there is no point showing boundary parents that
* are not shown. After rewrite_parents() rewrites the
* parents of a commit that is shown, we mark the boundary
* parents with BOUNDARY_SHOW.
*/
if (commit->object.flags & BOUNDARY_SHOW) {
commit->object.flags |= SHOWN;
return commit;
}
if (commit->object.flags & UNINTERESTING)
continue; continue;
if (revs->min_age != -1 && (commit->date > revs->min_age)) if (revs->min_age != -1 && (commit->date > revs->min_age))
continue; continue;
@ -907,6 +930,8 @@ struct commit *get_revision(struct rev_info *revs)
if (revs->parents) if (revs->parents)
rewrite_parents(revs, commit); rewrite_parents(revs, commit);
} }
if (revs->boundary)
mark_boundary_to_show(commit);
commit->object.flags |= SHOWN; commit->object.flags |= SHOWN;
return commit; return commit;
} while (revs->commits); } while (revs->commits);

3
revision.h

@ -7,7 +7,8 @@
#define SHOWN (1u<<3) #define SHOWN (1u<<3)
#define TMP_MARK (1u<<4) /* for isolated cases; clean after use */ #define TMP_MARK (1u<<4) /* for isolated cases; clean after use */
#define BOUNDARY (1u<<5) #define BOUNDARY (1u<<5)
#define ADDED (1u<<6) /* Parents already parsed and added? */ #define BOUNDARY_SHOW (1u<<6)
#define ADDED (1u<<7) /* Parents already parsed and added? */


struct rev_info; struct rev_info;



2
t/Makefile

@ -25,5 +25,5 @@ clean:
rm -fr trash rm -fr trash


.PHONY: $(T) clean .PHONY: $(T) clean
.NOPARALLEL: .NOTPARALLEL:



Loading…
Cancel
Save