kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

userdiff: support Java sealed classes 

A new kind of class was added in Java 17 -- sealed classes.[1]  This
feature includes several new keywords that may appear in a declaration
of a class.  New modifiers before name of the class: "sealed" and
"non-sealed", and a clause after name of the class marked by keyword
"permits".

The current set of regular expressions in userdiff.c already allows the
modifier "sealed" and the "permits" clause, but not the modifier
"non-sealed", which is the first hyphenated keyword in Java.[2]  Allow
hyphen in the words that precede the name of type to match the
"non-sealed" modifier.

In new input file "java-sealed" for the test t4018-diff-funcname.sh, use
a Java code comment for the marker "RIGHT".  This workaround is needed,
because the name of the sealed class appears on the line of code that
has the "ChangeMe" marker.

[1] Detailed description in "JEP 409: Sealed Classes"
    https://openjdk.org/jeps/409
[2] "JEP draft: Keyword Management for the Java Language"
    https://openjdk.org/jeps/8223002

Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
Reviewed-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Andrei Rybak 2023-02-08 00:42:59 +01:00 committed by Junio C Hamano
parent 575e6fcfcc
commit 93d52ed050
7 changed files with 40 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
t/t4018/java-non-sealed Normal file
View File

@ -0,0 +1,8 @@
public abstract sealed class SealedClass {
public static non-sealed class RIGHT extends SealedClass {
static int ONE;
static int TWO;
static int THREE;
private int ChangeMe;
}
}

7
t/t4018/java-sealed Normal file
View File

@ -0,0 +1,7 @@
public abstract sealed class Sealed { // RIGHT
static int ONE;
static int TWO;
static int THREE;
public final class ChangeMe extends Sealed {
}
}

6
t/t4018/java-sealed-permits Normal file
View File

@ -0,0 +1,6 @@
public abstract sealed class RIGHT permits PermittedA, PermittedB {
static int ONE;
static int TWO;
static int THREE;
private int ChangeMe;
}

6
t/t4018/java-sealed-type-parameters Normal file
View File

@ -0,0 +1,6 @@
public abstract sealed class RIGHT<A, B> {
static int ONE;
static int TWO;
static int THREE;
private int ChangeMe;
}

6
t/t4018/java-sealed-type-parameters-implements-permits Normal file
View File

@ -0,0 +1,6 @@
public abstract sealed class RIGHT<A, B> implements List<A> permits PermittedA, PermittedB {
static int ONE;
static int TWO;
static int THREE;
private int ChangeMe;
}

6
t/t4018/java-sealed-type-parameters-permits Normal file
View File

@ -0,0 +1,6 @@
public abstract sealed class RIGHT<A, B> permits PermittedA, PermittedB {
static int ONE;
static int TWO;
static int THREE;
private int ChangeMe;
}

2
userdiff.c
View File

@ -171,7 +171,7 @@ PATTERNS("html",
PATTERNS("java",
"!^[ \t]*(catch|do|for|if|instanceof|new|return|switch|throw|while)\n"
/* Class, enum, interface, and record declarations */
"^[ \t]*(([a-z]+[ \t]+)*(class|enum|interface|record)[ \t]+.*)$\n"
"^[ \t]*(([a-z-]+[ \t]+)*(class|enum|interface|record)[ \t]+.*)$\n"
/* Method definitions; note that constructor signatures are not */
/* matched because they are indistinguishable from method calls. */
"^[ \t]*(([A-Za-z_<>&][][?&<>.,A-Za-z_0-9]*[ \t]+)+[A-Za-z_][A-Za-z_0-9]*[ \t]*\\([^;]*)$",