kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

msvc: avoid calling `access("NUL", flags)` 

Apparently this is not supported with Microsoft's Universal C Runtime.
So let's not actually do that.

Instead, just return success because we _know_ that we expect the `NUL`
device to be present.

Side note: it is possible to turn off the "Null device driver" and
thereby disable `NUL`. Too many things are broken if this driver is
disabled, therefore it is not worth bothering to try to detect its
presence when `access()` is called.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Johannes Schindelin 2021-04-16 13:21:01 +02:00 committed by Junio C Hamano
parent 48bf2fa8ba
commit 9160068ac6
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compat/mingw.c
View File

@ -685,6 +685,8 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
int mingw_access(const char *filename, int mode) int mingw_access(const char *filename, int mode)
{ {
wchar_t wfilename[MAX_PATH]; wchar_t wfilename[MAX_PATH];
if (!strcmp("nul", filename) || !strcmp("/dev/null", filename))
return 0;
if (xutftowcs_path(wfilename, filename) < 0) if (xutftowcs_path(wfilename, filename) < 0)
return -1; return -1;
/* X_OK is not supported by the MSVCRT version */ /* X_OK is not supported by the MSVCRT version */