kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

Fix "checkout-cache.c" mis-use of read_sha1_file() interface. 

It's supposed to test the returned file type, not think that read_sha1_file()
tests it. Confusion from "cat-file" command line usage.
maint
Linus Torvalds 2005-04-09 11:24:41 -07:00
parent f7391ce3bd
commit 8d3af1d532
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
checkout-cache.c
View File

@ -42,9 +42,10 @@ static int write_entry(struct cache_entry *ce)
void *new; void *new;
unsigned long size; unsigned long size;
long wrote; long wrote;
char type[20];


new = read_sha1_file(ce->sha1, "blob", &size); new = read_sha1_file(ce->sha1, type, &size);
if (!new) { if (!new || strcmp(type, "blob")) {
fprintf(stderr, "checkout-cache: unable to read sha1 file of %s (%s)\n", fprintf(stderr, "checkout-cache: unable to read sha1 file of %s (%s)\n",
ce->name, sha1_to_hex(ce->sha1)); ce->name, sha1_to_hex(ce->sha1));
return -1; return -1;