kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity
Browse Source

add is_dot_or_dotdot inline function 

A new inline function is_dot_or_dotdot is used to check if the
directory name is either "." or "..". It returns a non-zero value if
the given string is "." or "..". It's applicable to a lot of Git
source code.

Signed-off-by: Alexander Potashev <aspotashev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Alexander Potashev 16 years ago committed by Junio C Hamano
parent
c123b7c5fb
commit
8ca12c0d62
9 changed files with 31 additions and 47 deletions
Split View
  1. 5
      builtin-count-objects.c
  2. 14
      builtin-fsck.c
  3. 14
      builtin-prune.c
  4. 11
      builtin-rerere.c
  5. 12
      dir.c
  6. 7
      dir.h
  7. 5
      entry.c
  8. 6
      remote.c
  9. 4
      transport.c

5
builtin-count-objects.c
Unescape View File

@ -5,6 +5,7 @@ @@ -5,6 +5,7 @@
*/

#include "cache.h"
#include "dir.h"
#include "builtin.h"
#include "parse-options.h"

@ -21,9 +22,7 @@ static void count_objects(DIR *d, char *path, int len, int verbose, @@ -21,9 +22,7 @@ static void count_objects(DIR *d, char *path, int len, int verbose,
const char *cp;
int bad = 0;

if ((ent->d_name[0] == '.') &&
(ent->d_name[1] == 0 ||
((ent->d_name[1] == '.') && (ent->d_name[2] == 0))))
if (is_dot_or_dotdot(ent->d_name))
continue;
for (cp = ent->d_name; *cp; cp++) {
int ch = *cp;

14
builtin-fsck.c
Unescape View File

@ -10,6 +10,7 @@ @@ -10,6 +10,7 @@
#include "tree-walk.h"
#include "fsck.h"
#include "parse-options.h"
#include "dir.h"

#define REACHABLE 0x0001
#define SEEN 0x0002
@ -395,19 +396,12 @@ static void fsck_dir(int i, char *path) @@ -395,19 +396,12 @@ static void fsck_dir(int i, char *path)
while ((de = readdir(dir)) != NULL) {
char name[100];
unsigned char sha1[20];
int len = strlen(de->d_name);

switch (len) {
case 2:
if (de->d_name[1] != '.')
break;
case 1:
if (de->d_name[0] != '.')
break;
if (is_dot_or_dotdot(de->d_name))
continue;
case 38:
if (strlen(de->d_name) == 38) {
sprintf(name, "%02x", i);
memcpy(name+2, de->d_name, len+1);
memcpy(name+2, de->d_name, 39);
if (get_sha1_hex(name, sha1) < 0)
break;
add_sha1_list(sha1, DIRENT_SORT_HINT(de));

14
builtin-prune.c
Unescape View File

@ -5,6 +5,7 @@ @@ -5,6 +5,7 @@
#include "builtin.h"
#include "reachable.h"
#include "parse-options.h"
#include "dir.h"

static const char * const prune_usage[] = {
"git prune [-n] [-v] [--expire <time>] [--] [<head>...]",
@ -61,19 +62,12 @@ static int prune_dir(int i, char *path) @@ -61,19 +62,12 @@ static int prune_dir(int i, char *path)
while ((de = readdir(dir)) != NULL) {
char name[100];
unsigned char sha1[20];
int len = strlen(de->d_name);

switch (len) {
case 2:
if (de->d_name[1] != '.')
break;
case 1:
if (de->d_name[0] != '.')
break;
if (is_dot_or_dotdot(de->d_name))
continue;
case 38:
if (strlen(de->d_name) == 38) {
sprintf(name, "%02x", i);
memcpy(name+2, de->d_name, len+1);
memcpy(name+2, de->d_name, 39);
if (get_sha1_hex(name, sha1) < 0)
break;


11
builtin-rerere.c
Unescape View File

@ -1,5 +1,6 @@ @@ -1,5 +1,6 @@
#include "builtin.h"
#include "cache.h"
#include "dir.h"
#include "string-list.h"
#include "rerere.h"
#include "xdiff/xdiff.h"
@ -59,17 +60,15 @@ static void garbage_collect(struct string_list *rr) @@ -59,17 +60,15 @@ static void garbage_collect(struct string_list *rr)
git_config(git_rerere_gc_config, NULL);
dir = opendir(git_path("rr-cache"));
while ((e = readdir(dir))) {
const char *name = e->d_name;
if (name[0] == '.' &&
(name[1] == '\0' || (name[1] == '.' && name[2] == '\0')))
if (is_dot_or_dotdot(e->d_name))
continue;
then = rerere_created_at(name);
then = rerere_created_at(e->d_name);
if (!then)
continue;
cutoff = (has_resolution(name)
cutoff = (has_resolution(e->d_name)
? cutoff_resolve : cutoff_noresolve);
if (then < now - cutoff * 86400)
string_list_append(name, &to_remove);
string_list_append(e->d_name, &to_remove);
}
for (i = 0; i < to_remove.nr; i++)
unlink_rr_item(to_remove.items[i].string);

12
dir.c
Unescape View File

@ -585,10 +585,8 @@ static int read_directory_recursive(struct dir_struct *dir, const char *path, co @@ -585,10 +585,8 @@ static int read_directory_recursive(struct dir_struct *dir, const char *path, co
int len, dtype;
int exclude;

if ((de->d_name[0] == '.') &&
(de->d_name[1] == 0 ||
!strcmp(de->d_name + 1, ".") ||
!strcmp(de->d_name + 1, "git")))
if (is_dot_or_dotdot(de->d_name) ||
!strcmp(de->d_name, ".git"))
continue;
len = strlen(de->d_name);
/* Ignore overly long pathnames! */
@ -793,10 +791,8 @@ int remove_dir_recursively(struct strbuf *path, int only_empty) @@ -793,10 +791,8 @@ int remove_dir_recursively(struct strbuf *path, int only_empty)
len = path->len;
while ((e = readdir(dir)) != NULL) {
struct stat st;
if ((e->d_name[0] == '.') &&
((e->d_name[1] == 0) ||
((e->d_name[1] == '.') && e->d_name[2] == 0)))
continue; /* "." and ".." */
if (is_dot_or_dotdot(e->d_name))
continue;

strbuf_setlen(path, len);
strbuf_addstr(path, e->d_name);

7
dir.h
Unescape View File

@ -77,6 +77,13 @@ extern int file_exists(const char *); @@ -77,6 +77,13 @@ extern int file_exists(const char *);
extern char *get_relative_cwd(char *buffer, int size, const char *dir);
extern int is_inside_dir(const char *dir);

static inline int is_dot_or_dotdot(const char *name)
{
return (name[0] == '.' &&
(name[1] == '\0' ||
(name[1] == '.' && name[2] == '\0')));
}

extern void setup_standard_excludes(struct dir_struct *dir);
extern int remove_dir_recursively(struct strbuf *path, int only_empty);


5
entry.c
Unescape View File

@ -1,5 +1,6 @@ @@ -1,5 +1,6 @@
#include "cache.h"
#include "blob.h"
#include "dir.h"

static void create_directories(const char *path, const struct checkout *state)
{
@ -62,9 +63,7 @@ static void remove_subtree(const char *path) @@ -62,9 +63,7 @@ static void remove_subtree(const char *path)
*name++ = '/';
while ((de = readdir(dir)) != NULL) {
struct stat st;
if ((de->d_name[0] == '.') &&
((de->d_name[1] == 0) ||
((de->d_name[1] == '.') && de->d_name[2] == 0)))
if (is_dot_or_dotdot(de->d_name))
continue;
strcpy(name, de->d_name);
if (lstat(pathbuf, &st))

6
remote.c
Unescape View File

@ -4,6 +4,7 @@ @@ -4,6 +4,7 @@
#include "commit.h"
#include "diff.h"
#include "revision.h"
#include "dir.h"

static struct refspec s_tag_refspec = {
0,
@ -634,10 +635,7 @@ static struct refspec *parse_push_refspec(int nr_refspec, const char **refspec) @@ -634,10 +635,7 @@ static struct refspec *parse_push_refspec(int nr_refspec, const char **refspec)

static int valid_remote_nick(const char *name)
{
if (!name[0] || /* not empty */
(name[0] == '.' && /* not "." */
(!name[1] || /* not ".." */
(name[1] == '.' && !name[2]))))
if (!name[0] || is_dot_or_dotdot(name))
return 0;
return !strchr(name, '/'); /* no slash */
}

4
transport.c
Unescape View File

@ -50,9 +50,7 @@ static int read_loose_refs(struct strbuf *path, int name_offset, @@ -50,9 +50,7 @@ static int read_loose_refs(struct strbuf *path, int name_offset,
memset (&list, 0, sizeof(list));

while ((de = readdir(dir))) {
if (de->d_name[0] == '.' && (de->d_name[1] == '\0' ||
(de->d_name[1] == '.' &&
de->d_name[2] == '\0')))
if (is_dot_or_dotdot(de->d_name))
continue;
ALLOC_GROW(list.entries, list.nr + 1, list.alloc);
list.entries[list.nr++] = xstrdup(de->d_name);

Write Preview
Loading…
Cancel
Save