Browse Source

range-diff: avoid leaking memory in two error code paths

In the code paths in question, we already release a lot of memory, but
the `current_filename` variable was missed. Fix that.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Johannes Schindelin 4 years ago committed by Junio C Hamano
parent
commit
8c29b49794
  1. 2
      range-diff.c

2
range-diff.c

@ -97,6 +97,7 @@ static int read_patches(const char *range, struct string_list *list, @@ -97,6 +97,7 @@ static int read_patches(const char *range, struct string_list *list,
if (get_oid(p, &util->oid)) {
error(_("could not parse commit '%s'"), p);
free(util);
free(current_filename);
string_list_clear(list, 1);
strbuf_release(&buf);
strbuf_release(&contents);
@ -112,6 +113,7 @@ static int read_patches(const char *range, struct string_list *list, @@ -112,6 +113,7 @@ static int read_patches(const char *range, struct string_list *list,
error(_("could not parse first line of `log` output: "
"did not start with 'commit ': '%s'"),
line);
free(current_filename);
string_list_clear(list, 1);
strbuf_release(&buf);
strbuf_release(&contents);

Loading…
Cancel
Save