Merge branch 'maint'
* maint: Increase the size of the die/warning buffer to avoid truncation close_sha1_file(): make it easier to diagnose errors avoid possible overflow in delta size filtering computationmaint
commit
89fbda2425
|
|
@ -1293,7 +1293,7 @@ static int try_delta(struct unpacked *trg, struct unpacked *src,
|
||||||
max_size = trg_entry->delta_size;
|
max_size = trg_entry->delta_size;
|
||||||
ref_depth = trg->depth;
|
ref_depth = trg->depth;
|
||||||
}
|
}
|
||||||
max_size = max_size * (max_depth - src->depth) /
|
max_size = (uint64_t)max_size * (max_depth - src->depth) /
|
||||||
(max_depth - ref_depth + 1);
|
(max_depth - ref_depth + 1);
|
||||||
if (max_size == 0)
|
if (max_size == 0)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
|
||||||
|
|
@ -2287,7 +2287,7 @@ static void close_sha1_file(int fd)
|
||||||
fsync_or_die(fd, "sha1 file");
|
fsync_or_die(fd, "sha1 file");
|
||||||
fchmod(fd, 0444);
|
fchmod(fd, 0444);
|
||||||
if (close(fd) != 0)
|
if (close(fd) != 0)
|
||||||
die("unable to write sha1 file");
|
die("error when closing sha1 file (%s)", strerror(errno));
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Size of directory component, including the ending '/' */
|
/* Size of directory component, including the ending '/' */
|
||||||
|
|
|
||||||
2
usage.c
2
usage.c
|
|
@ -7,7 +7,7 @@
|
||||||
|
|
||||||
static void report(const char *prefix, const char *err, va_list params)
|
static void report(const char *prefix, const char *err, va_list params)
|
||||||
{
|
{
|
||||||
char msg[256];
|
char msg[1024];
|
||||||
vsnprintf(msg, sizeof(msg), err, params);
|
vsnprintf(msg, sizeof(msg), err, params);
|
||||||
fprintf(stderr, "%s%s\n", prefix, msg);
|
fprintf(stderr, "%s%s\n", prefix, msg);
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue