Browse Source

Stop starting pager recursively

git-column can be used as a pager for other git commands, something
like this:

    GIT_PAGER="git -p column --mode='dense color'" git -p branch

The problem with this is that "git -p column" also has $GIT_PAGER set so
the pager runs itself again as another pager. The end result is an
infinite loop of forking. Other git commands have the same problem if
being abused this way.

Check if $GIT_PAGER is already set and stop launching another pager.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Nguyễn Thái Ngọc Duy 13 years ago committed by Junio C Hamano
parent
commit
88e8f908f2
  1. 2
      pager.c

2
pager.c

@ -73,7 +73,7 @@ void setup_pager(void) @@ -73,7 +73,7 @@ void setup_pager(void)
{
const char *pager = git_pager(isatty(1));

if (!pager)
if (!pager || pager_in_use())
return;

/*

Loading…
Cancel
Save