Browse Source

builtin/get-tar-commit-id: make hash size independent

To make this code independent of the hash size, verify that the length
of the comment is equal to that of any supported hash algorithm.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
brian m. carlson 6 years ago committed by Junio C Hamano
parent
commit
87003d2c94
  1. 3
      builtin/get-tar-commit-id.c

3
builtin/get-tar-commit-id.c

@ -41,7 +41,8 @@ int cmd_get_tar_commit_id(int argc, const char **argv, const char *prefix)
if (!skip_prefix(end, " comment=", &comment)) if (!skip_prefix(end, " comment=", &comment))
return 1; return 1;
len -= comment - content; len -= comment - content;
if (len != GIT_SHA1_HEXSZ + 1) if (len < 1 || !(len % 2) ||
hash_algo_by_length((len - 1) / 2) == GIT_HASH_UNKNOWN)
return 1; return 1;


if (write_in_full(1, comment, len) < 0) if (write_in_full(1, comment, len) < 0)

Loading…
Cancel
Save