"git pull" doesn't know "--edit"
Ok, so now "git merge" defaults to editing when interactive - lovely. But
when testing that, I noticed that while you can say
git merge --[no-]edit ..branch..
that does not work with "git pull". You get a message like
error: unknown option `no-edit'
usage: git fetch [<options>] [<repository> [<refspec>...]]
or: git fetch [<options>] <group>
or: git fetch --multiple [<options>] [(<repository> | <group>)...]
or: git fetch --all [<options>]
-v, --verbose be more verbose
-q, --quiet be more quiet
--all fetch from all remotes
...
which is because that stupid shell script doesn't know about the new
flags, and just passes it to "git fetch" instead.
Now, I really wanted to just make "git pull" a built-in instead of that
nasty shell script, but I'm lazy. So here's the trivial updates to
git-pull.sh to at least teach it about -e/--edit/--no-edit.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
parent
fd6abd0c65
commit
8580830084
|
|
@ -40,7 +40,7 @@ test -f "$GIT_DIR/MERGE_HEAD" && die_merge
|
||||||
|
|
||||||
strategy_args= diffstat= no_commit= squash= no_ff= ff_only=
|
strategy_args= diffstat= no_commit= squash= no_ff= ff_only=
|
||||||
log_arg= verbosity= progress= recurse_submodules=
|
log_arg= verbosity= progress= recurse_submodules=
|
||||||
merge_args=
|
merge_args= edit=
|
||||||
curr_branch=$(git symbolic-ref -q HEAD)
|
curr_branch=$(git symbolic-ref -q HEAD)
|
||||||
curr_branch_short="${curr_branch#refs/heads/}"
|
curr_branch_short="${curr_branch#refs/heads/}"
|
||||||
rebase=$(git config --bool branch.$curr_branch_short.rebase)
|
rebase=$(git config --bool branch.$curr_branch_short.rebase)
|
||||||
|
|
@ -70,6 +70,10 @@ do
|
||||||
no_commit=--no-commit ;;
|
no_commit=--no-commit ;;
|
||||||
--c|--co|--com|--comm|--commi|--commit)
|
--c|--co|--com|--comm|--commi|--commit)
|
||||||
no_commit=--commit ;;
|
no_commit=--commit ;;
|
||||||
|
-e|--edit)
|
||||||
|
edit=--edit ;;
|
||||||
|
--no-edit)
|
||||||
|
edit=--no-edit ;;
|
||||||
--sq|--squ|--squa|--squas|--squash)
|
--sq|--squ|--squa|--squas|--squash)
|
||||||
squash=--squash ;;
|
squash=--squash ;;
|
||||||
--no-sq|--no-squ|--no-squa|--no-squas|--no-squash)
|
--no-sq|--no-squ|--no-squa|--no-squas|--no-squash)
|
||||||
|
|
@ -278,7 +282,7 @@ true)
|
||||||
eval="$eval --onto $merge_head ${oldremoteref:-$merge_head}"
|
eval="$eval --onto $merge_head ${oldremoteref:-$merge_head}"
|
||||||
;;
|
;;
|
||||||
*)
|
*)
|
||||||
eval="git-merge $diffstat $no_commit $squash $no_ff $ff_only"
|
eval="git-merge $diffstat $no_commit $edit $squash $no_ff $ff_only"
|
||||||
eval="$eval $log_arg $strategy_args $merge_args $verbosity $progress"
|
eval="$eval $log_arg $strategy_args $merge_args $verbosity $progress"
|
||||||
eval="$eval \"\$merge_name\" HEAD $merge_head"
|
eval="$eval \"\$merge_name\" HEAD $merge_head"
|
||||||
;;
|
;;
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue