Browse Source

http-push: avoid a needless goto

There was a goto, and while it is not half as harmful as some people
believe, it was unnecessary here.  So remove it for readability.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Johannes Schindelin 17 years ago committed by Junio C Hamano
parent
commit
7fea9c5514
  1. 5
      http-push.c

5
http-push.c

@ -2413,12 +2413,9 @@ int main(int argc, char **argv) @@ -2413,12 +2413,9 @@ int main(int argc, char **argv)
} while (request_queue_head && !aborted);

/* Update the remote branch if all went well */
if (aborted || !update_remote(ref->new_sha1, ref_lock)) {
if (aborted || !update_remote(ref->new_sha1, ref_lock))
rc = 1;
goto unlock;
}

unlock:
if (!rc)
fprintf(stderr, " done\n");
unlock_remote(ref_lock);

Loading…
Cancel
Save