kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

sparse-checkout: create leading directory 

When creating the sparse-checkout file, Git does not create the leading
directory, "$GIT_DIR/info", if it does not exist. This causes problems
if the repository does not have that directory. Therefore, ensure that
the leading directory is created.

This is the only "open" in builtin/sparse-checkout.c that does not have
a leading directory check. (The other one in write_patterns_and_update()
does.)

Note that the test needs to explicitly specify a template when running
"git init" because the default template used in the tests has the
"info/" directory included.

Helped-by: Jose Lopes <jabolopes@google.com>
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Jonathan Tan 2022-01-21 09:44:41 -08:00 committed by Junio C Hamano
parent e9d7761bb9
commit 7f44842ac1
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
builtin/sparse-checkout.c
View File

@ -450,6 +450,9 @@ static int sparse_checkout_init(int argc, const char **argv)
FILE *fp; FILE *fp;


/* assume we are in a fresh repo, but update the sparse-checkout file */ /* assume we are in a fresh repo, but update the sparse-checkout file */
if (safe_create_leading_directories(sparse_filename))
die(_("unable to create leading directories of %s"),
sparse_filename);
fp = xfopen(sparse_filename, "w"); fp = xfopen(sparse_filename, "w");
if (!fp) if (!fp)
die(_("failed to open '%s'"), sparse_filename); die(_("failed to open '%s'"), sparse_filename);

6
t/t1091-sparse-checkout-builtin.sh
View File

@ -71,6 +71,12 @@ test_expect_success 'git sparse-checkout init' '
check_files repo a check_files repo a
' '


test_expect_success 'git sparse-checkout init in empty repo' '
test_when_finished rm -rf empty-repo blank-template &&
git init --template= empty-repo &&
git -C empty-repo sparse-checkout init
'

test_expect_success 'git sparse-checkout list after init' ' test_expect_success 'git sparse-checkout list after init' '
git -C repo sparse-checkout list >actual && git -C repo sparse-checkout list >actual &&
cat >expect <<-\EOF && cat >expect <<-\EOF &&