kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

am/apply: warn if we end up reading patches from terminal 

In an interactive session, "git am" without arguments, or even
worse, "git am --whitespace file", waits silently for the user to
feed the patches from the standard input (presumably by typing or
copy-pasting).  Give a feedback message to the user when this
happens, as it is unlikely that the user meant to do so.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Junio C Hamano 2022-03-03 13:58:39 -08:00
parent 4c53a8c20f
commit 7b20af6a06
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
builtin/mailsplit.c
View File

@ -223,6 +223,9 @@ static int split_mbox(const char *file, const char *dir, int allow_bare,
FILE *f = !strcmp(file, "-") ? stdin : fopen(file, "r"); FILE *f = !strcmp(file, "-") ? stdin : fopen(file, "r");
int file_done = 0; int file_done = 0;


if (isatty(fileno(f)))
warning(_("reading patches from stdin/tty..."));

if (!f) { if (!f) {
error_errno("cannot open mbox %s", file); error_errno("cannot open mbox %s", file);
goto out; goto out;