kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

config: flip return value of write_section() 

d9bd4cbb9c (config: flip return value of store_write_*()) made
write_section() follow the convention of write(2) to return -1 on error
and the number of written bytes on success.  3b48045c6c (Merge branch
'sd/branch-copy') changed it back to returning 0 on error and 1 on
success, but left its callers still checking for negative values.

Let write_section() follow the convention of write(2) again to meet the
expectations of its callers.

Reported-by: Jeff King <peff@peff.net>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
René Scharfe 2017-11-18 11:20:04 +01:00 committed by Junio C Hamano
parent 3b48045c6c
commit 782c030ea2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config.c
View File

@ -2319,7 +2319,7 @@ static ssize_t write_section(int fd, const char *key)
struct strbuf sb = store_create_section(key); struct strbuf sb = store_create_section(key);
ssize_t ret; ssize_t ret;


ret = write_in_full(fd, sb.buf, sb.len) == sb.len; ret = write_in_full(fd, sb.buf, sb.len);
strbuf_release(&sb); strbuf_release(&sb);


return ret; return ret;