kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

pack-redundant: fix memory leak when open_pack_index() fails 

In add_pack(), we allocate l.remaining_objects with llist_init() before
calling open_pack_index(). If open_pack_index() fails we return NULL
without freeing the allocated list, leaking the memory.

Fix by calling llist_free(l.remaining_objects) on the error path before
returning.

Signed-off-by: Sahitya Chandra <sahityajb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Sahitya Chandra 2026-02-21 16:08:59 +05:30 committed by Junio C Hamano
parent 67ad42147a
commit 7451864bfa
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/pack-redundant.c
View File

@ -546,8 +546,10 @@ static struct pack_list * add_pack(struct packed_git *p)
l.pack = p;
llist_init(&l.remaining_objects);

if (open_pack_index(p))
if (open_pack_index(p)) {
llist_free(l.remaining_objects);
return NULL;
}

base = p->index_data;
base += 256 * 4 + ((p->index_version < 2) ? 4 : 8);