kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

pack-bitmap: reword comments in test_bitmap_commits() 

The comment in pack-bitmap.c:test_bitmap_commits(), suggests that
we can avoid reading the commit table altogether. However, this
comment is misleading. The reason we load bitmap entries here is
because test_bitmap_commits() needs to print the commit IDs from the
bitmap, and we must read the bitmap entries to obtain those commit IDs.
So reword this comment.

Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Lidong Yan 2025-07-01 05:32:08 +00:00 committed by Junio C Hamano
parent 3367b6657c
commit 73bf771b95
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pack-bitmap.c
View File

@ -2839,8 +2839,9 @@ int test_bitmap_commits(struct repository *r)
die(_("failed to load bitmap indexes"));

/*
* As this function is only used to print bitmap selected
* commits, we don't have to read the commit table.
* Since this function needs to print the bitmapped
* commits, bypass the commit lookup table (if one exists)
* by forcing the bitmap to eagerly load its entries.
*/
if (bitmap_git->table_lookup) {
if (load_bitmap_entries_v1(bitmap_git) < 0)