From 6c4cca1c72f98c84a21a2d1916a8e86be57d26e6 Mon Sep 17 00:00:00 2001 From: "Eric W. Biederman" Date: Mon, 12 Jun 2006 13:31:38 -0600 Subject: [PATCH] Fix git-format-patch -s When git-format-patch was converted to a builtin an appropriate call to setup_ident was missed and thus git-format-patch -s fails because it doesn't look up anything in the password file. Signed-off-by: Eric W. Biederman Signed-off-by: Junio C Hamano --- builtin-log.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/builtin-log.c b/builtin-log.c index 6afa66ce02..9187fd337b 100644 --- a/builtin-log.c +++ b/builtin-log.c @@ -220,8 +220,11 @@ int cmd_format_patch(int argc, const char **argv, char **envp) } else if (!strcmp(argv[i], "--signoff") || !strcmp(argv[i], "-s")) { - const char *committer = git_committer_info(1); - const char *endpos = strchr(committer, '>'); + const char *committer; + const char *endpos; + setup_ident(); + committer = git_committer_info(1); + endpos = strchr(committer, '>'); if (!endpos) die("bogos committer info %s\n", committer); add_signoff = xmalloc(endpos - committer + 2);