help: release strbuf on error return in exec_man_man()

Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
8 years ago · 7246218667
1 changed files with 1 additions and 0 deletions
--- a/builtin/help.c
+++ b/builtin/help.c
@ -170,6 +170,7 @@ static void exec_man_cmd(const char *cmd, const char *page)
				@@ -170,6 +170,7 @@ static void exec_man_cmd(const char *cmd, const char *page)
 	strbuf_addf(&shell_cmd, "%s %s", cmd, page);
 	execl(SHELL_PATH, SHELL_PATH, "-c", shell_cmd.buf, (char *)NULL);
 	warning(_("failed to exec '%s'"), cmd);
+	strbuf_release(&shell_cmd);
 }

 static void add_man_viewer(const char *name)