Browse Source

shortlog: do not crash on parsing "[PATCH"

Annoyingly, it looked for the closing bracket in the author name
instead of in the message, and then accessed the NULL pointer.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
maint
Johannes Schindelin 18 years ago committed by Junio C Hamano
parent
commit
72019cdefe
  1. 16
      builtin-shortlog.c

16
builtin-shortlog.c

@ -108,13 +108,15 @@ static void insert_author_oneline(struct path_list *list, @@ -108,13 +108,15 @@ static void insert_author_oneline(struct path_list *list,
free(buffer);

if (!strncmp(oneline, "[PATCH", 6)) {
char *eob = strchr(buffer, ']');

while (isspace(eob[1]) && eob[1] != '\n')
eob++;
if (eob - oneline < onelinelen) {
onelinelen -= eob - oneline;
oneline = eob;
char *eob = strchr(oneline, ']');

if (eob) {
while (isspace(eob[1]) && eob[1] != '\n')
eob++;
if (eob - oneline < onelinelen) {
onelinelen -= eob - oneline;
oneline = eob;
}
}
}


Loading…
Cancel
Save