Browse Source

git-gui: Correct starting of git-remote to handle -w option

Current versions of git-remote apparently are passing the -w option
to Perl as part of the shbang line:

  #!/usr/bin/perl -w

this caused a problem in git-gui and gave the user a Tcl error with
the message: "git-remote not supported: #!/usr/bin/perl -w".

The fix for this is to treat the shbang line as a Tcl list and look
at the first element only for guessing the executable name.  Once
we know the executable name we use the remaining elements (if any
exist) as arguments to the executable, before the script filename.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
maint
Shawn O. Pearce 18 years ago
parent
commit
6e4ba05c7f
  1. 4
      git-gui.sh

4
git-gui.sh

@ -261,7 +261,7 @@ proc _git_cmd {name} {
set s [gets $f] set s [gets $f]
close $f close $f


switch -glob -- $s { switch -glob -- [lindex $s 0] {
#!*sh { set i sh } #!*sh { set i sh }
#!*perl { set i perl } #!*perl { set i perl }
#!*python { set i python } #!*python { set i python }
@ -275,7 +275,7 @@ proc _git_cmd {name} {
if {$interp eq {}} { if {$interp eq {}} {
error "git-$name requires $i (not in PATH)" error "git-$name requires $i (not in PATH)"
} }
set v [list $interp $p] set v [concat [list $interp] [lrange $s 1 end] [list $p]]
} else { } else {
# Assume it is builtin to git somehow and we # Assume it is builtin to git somehow and we
# aren't actually able to see a file for it. # aren't actually able to see a file for it.

Loading…
Cancel
Save