kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

t7500: fix GIT_EDITOR shell snippet 

2140b140 (commit: error out for missing commit message template,
2011-02-25) defined

    GIT_EDITOR="echo hello >\"\$1\""

for these two tests, with the intention that 'hello' would be
written in the given file, but as Phillip Wood points out,
GIT_EDITOR is invoked by shell after getting expanded to

    sh -c 'echo hello >"$1" "$@"' 'echo hello >"$1"' path/to/file

which is not what we want.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
main
Junio C Hamano 2025-10-06 13:07:18 -07:00
parent 666b29b58f
commit 6b4f07325d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
t/t7500-commit-template-squash-signoff.sh
View File

@ -31,7 +31,7 @@ test_expect_success 'nonexistent template file should return error' '
echo changes >> foo &&
git add foo &&
(
GIT_EDITOR="echo hello >\"\$1\"" &&
GIT_EDITOR="echo hello >" &&
export GIT_EDITOR &&
test_must_fail git commit --template "$PWD"/notexist
)
@ -40,7 +40,7 @@ test_expect_success 'nonexistent template file should return error' '
test_expect_success 'nonexistent template file in config should return error' '
test_config commit.template "$PWD"/notexist &&
(
GIT_EDITOR="echo hello >\"\$1\"" &&
GIT_EDITOR="echo hello >" &&
export GIT_EDITOR &&
test_must_fail git commit --allow-empty
)