Browse Source

coccinelle: make use of the "type" FREE_AND_NULL() rule

Apply the result of the just-added coccinelle rule. This manually
excludes a few occurrences, mostly things that resulted in many
FREE_AND_NULL() on one line, that'll be manually fixed in a subsequent
change.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Ævar Arnfjörð Bjarmason 7 years ago committed by Junio C Hamano
parent
commit
6a83d90207
  1. 6
      alias.c
  2. 3
      apply.c
  3. 6
      attr.c
  4. 3
      branch.c
  5. 3
      builtin/am.c
  6. 6
      builtin/clean.c
  7. 6
      builtin/config.c
  8. 6
      builtin/index-pack.c
  9. 12
      builtin/pack-objects.c
  10. 3
      builtin/unpack-objects.c
  11. 3
      commit.c
  12. 3
      config.c
  13. 3
      credential.c
  14. 3
      diff-lib.c
  15. 6
      diff.c
  16. 6
      diffcore-rename.c
  17. 9
      dir.c
  18. 6
      fast-import.c
  19. 3
      grep.c
  20. 24
      http-push.c
  21. 15
      http.c
  22. 3
      imap-send.c
  23. 3
      line-log.c
  24. 3
      mailinfo.c
  25. 3
      object.c
  26. 3
      pathspec.c
  27. 6
      read-cache.c
  28. 3
      ref-filter.c
  29. 3
      refs/files-backend.c
  30. 3
      remote-testsvn.c
  31. 3
      sequencer.c
  32. 3
      sha1-array.c
  33. 3
      sha1_file.c
  34. 27
      transport-helper.c
  35. 3
      transport.c
  36. 6
      tree-diff.c
  37. 3
      tree.c

6
alias.c

@ -47,8 +47,7 @@ int split_cmdline(char *cmdline, const char ***argv)
src++; src++;
c = cmdline[src]; c = cmdline[src];
if (!c) { if (!c) {
free(*argv); FREE_AND_NULL(*argv);
*argv = NULL;
return -SPLIT_CMDLINE_BAD_ENDING; return -SPLIT_CMDLINE_BAD_ENDING;
} }
} }
@ -60,8 +59,7 @@ int split_cmdline(char *cmdline, const char ***argv)
cmdline[dst] = 0; cmdline[dst] = 0;


if (quoted) { if (quoted) {
free(*argv); FREE_AND_NULL(*argv);
*argv = NULL;
return -SPLIT_CMDLINE_UNCLOSED_QUOTE; return -SPLIT_CMDLINE_UNCLOSED_QUOTE;
} }



3
apply.c

@ -3705,8 +3705,7 @@ static int check_preimage(struct apply_state *state,
is_new: is_new:
patch->is_new = 1; patch->is_new = 1;
patch->is_delete = 0; patch->is_delete = 0;
free(patch->old_name); FREE_AND_NULL(patch->old_name);
patch->old_name = NULL;
return 0; return 0;
} }



6
attr.c

@ -638,13 +638,11 @@ void attr_check_reset(struct attr_check *check)


void attr_check_clear(struct attr_check *check) void attr_check_clear(struct attr_check *check)
{ {
free(check->items); FREE_AND_NULL(check->items);
check->items = NULL;
check->alloc = 0; check->alloc = 0;
check->nr = 0; check->nr = 0;


free(check->all_attrs); FREE_AND_NULL(check->all_attrs);
check->all_attrs = NULL;
check->all_attrs_nr = 0; check->all_attrs_nr = 0;


drop_attr_stack(&check->stack); drop_attr_stack(&check->stack);

3
branch.c

@ -24,8 +24,7 @@ static int find_tracked_branch(struct remote *remote, void *priv)
} else { } else {
free(tracking->spec.src); free(tracking->spec.src);
if (tracking->src) { if (tracking->src) {
free(tracking->src); FREE_AND_NULL(tracking->src);
tracking->src = NULL;
} }
} }
tracking->spec.src = NULL; tracking->spec.src = NULL;

3
builtin/am.c

@ -483,8 +483,7 @@ static int run_applypatch_msg_hook(struct am_state *state)
ret = run_hook_le(NULL, "applypatch-msg", am_path(state, "final-commit"), NULL); ret = run_hook_le(NULL, "applypatch-msg", am_path(state, "final-commit"), NULL);


if (!ret) { if (!ret) {
free(state->msg); FREE_AND_NULL(state->msg);
state->msg = NULL;
if (read_commit_msg(state) < 0) if (read_commit_msg(state) < 0)
die(_("'%s' was deleted by the applypatch-msg hook"), die(_("'%s' was deleted by the applypatch-msg hook"),
am_path(state, "final-commit")); am_path(state, "final-commit"));

6
builtin/clean.c

@ -837,8 +837,7 @@ static void interactive_main_loop(void)
int ret; int ret;
ret = menus[*chosen].fn(); ret = menus[*chosen].fn();
if (ret != MENU_RETURN_NO_LOOP) { if (ret != MENU_RETURN_NO_LOOP) {
free(chosen); FREE_AND_NULL(chosen);
chosen = NULL;
if (!del_list.nr) { if (!del_list.nr) {
clean_print_color(CLEAN_COLOR_ERROR); clean_print_color(CLEAN_COLOR_ERROR);
printf_ln(_("No more files to clean, exiting.")); printf_ln(_("No more files to clean, exiting."));
@ -851,8 +850,7 @@ static void interactive_main_loop(void)
quit_cmd(); quit_cmd();
} }


free(chosen); FREE_AND_NULL(chosen);
chosen = NULL;
break; break;
} }
} }

6
builtin/config.c

@ -214,8 +214,7 @@ static int get_value(const char *key_, const char *regex_)
key_regexp = (regex_t*)xmalloc(sizeof(regex_t)); key_regexp = (regex_t*)xmalloc(sizeof(regex_t));
if (regcomp(key_regexp, key, REG_EXTENDED)) { if (regcomp(key_regexp, key, REG_EXTENDED)) {
error("invalid key pattern: %s", key_); error("invalid key pattern: %s", key_);
free(key_regexp); FREE_AND_NULL(key_regexp);
key_regexp = NULL;
ret = CONFIG_INVALID_PATTERN; ret = CONFIG_INVALID_PATTERN;
goto free_strings; goto free_strings;
} }
@ -235,8 +234,7 @@ static int get_value(const char *key_, const char *regex_)
regexp = (regex_t*)xmalloc(sizeof(regex_t)); regexp = (regex_t*)xmalloc(sizeof(regex_t));
if (regcomp(regexp, regex_, REG_EXTENDED)) { if (regcomp(regexp, regex_, REG_EXTENDED)) {
error("invalid pattern: %s", regex_); error("invalid pattern: %s", regex_);
free(regexp); FREE_AND_NULL(regexp);
regexp = NULL;
ret = CONFIG_INVALID_PATTERN; ret = CONFIG_INVALID_PATTERN;
goto free_strings; goto free_strings;
} }

6
builtin/index-pack.c

@ -388,8 +388,7 @@ static struct base_data *alloc_base_data(void)
static void free_base_data(struct base_data *c) static void free_base_data(struct base_data *c)
{ {
if (c->data) { if (c->data) {
free(c->data); FREE_AND_NULL(c->data);
c->data = NULL;
get_thread_data()->base_cache_used -= c->size; get_thread_data()->base_cache_used -= c->size;
} }
} }
@ -605,8 +604,7 @@ static void *unpack_data(struct object_entry *obj,
git_inflate_end(&stream); git_inflate_end(&stream);
free(inbuf); free(inbuf);
if (consume) { if (consume) {
free(data); FREE_AND_NULL(data);
data = NULL;
} }
return data; return data;
} }

12
builtin/pack-objects.c

@ -264,8 +264,7 @@ static unsigned long write_no_reuse_object(struct sha1file *f, struct object_ent
* make sure no cached delta data remains from a * make sure no cached delta data remains from a
* previous attempt before a pack split occurred. * previous attempt before a pack split occurred.
*/ */
free(entry->delta_data); FREE_AND_NULL(entry->delta_data);
entry->delta_data = NULL;
entry->z_delta_size = 0; entry->z_delta_size = 0;
} else if (entry->delta_data) { } else if (entry->delta_data) {
size = entry->delta_size; size = entry->delta_size;
@ -1375,12 +1374,10 @@ static void cleanup_preferred_base(void)
if (!pbase_tree_cache[i]) if (!pbase_tree_cache[i])
continue; continue;
free(pbase_tree_cache[i]->tree_data); free(pbase_tree_cache[i]->tree_data);
free(pbase_tree_cache[i]); FREE_AND_NULL(pbase_tree_cache[i]);
pbase_tree_cache[i] = NULL;
} }


free(done_pbase_paths); FREE_AND_NULL(done_pbase_paths);
done_pbase_paths = NULL;
done_pbase_paths_num = done_pbase_paths_alloc = 0; done_pbase_paths_num = done_pbase_paths_alloc = 0;
} }


@ -1970,8 +1967,7 @@ static unsigned long free_unpacked(struct unpacked *n)
n->index = NULL; n->index = NULL;
if (n->data) { if (n->data) {
freed_mem += n->entry->size; freed_mem += n->entry->size;
free(n->data); FREE_AND_NULL(n->data);
n->data = NULL;
} }
n->entry = NULL; n->entry = NULL;
n->depth = 0; n->depth = 0;

3
builtin/unpack-objects.c

@ -112,8 +112,7 @@ static void *get_data(unsigned long size)
break; break;
if (ret != Z_OK) { if (ret != Z_OK) {
error("inflate returned %d", ret); error("inflate returned %d", ret);
free(buf); FREE_AND_NULL(buf);
buf = NULL;
if (!recover) if (!recover)
exit(1); exit(1);
has_errors = 1; has_errors = 1;

3
commit.c

@ -287,8 +287,7 @@ void free_commit_buffer(struct commit *commit)
{ {
struct commit_buffer *v = buffer_slab_peek(&buffer_slab, commit); struct commit_buffer *v = buffer_slab_peek(&buffer_slab, commit);
if (v) { if (v) {
free(v->buffer); FREE_AND_NULL(v->buffer);
v->buffer = NULL;
v->size = 0; v->size = 0;
} }
} }

3
config.c

@ -395,8 +395,7 @@ static int git_config_parse_key_1(const char *key, char **store_key, int *basele


out_free_ret_1: out_free_ret_1:
if (store_key) { if (store_key) {
free(*store_key); FREE_AND_NULL(*store_key);
*store_key = NULL;
} }
return -CONFIG_INVALID_KEY; return -CONFIG_INVALID_KEY;
} }

3
credential.c

@ -93,8 +93,7 @@ static void credential_apply_config(struct credential *c)
c->configured = 1; c->configured = 1;


if (!c->use_http_path && proto_is_http(c->protocol)) { if (!c->use_http_path && proto_is_http(c->protocol)) {
free(c->path); FREE_AND_NULL(c->path);
c->path = NULL;
} }
} }



3
diff-lib.c

@ -179,8 +179,7 @@ int run_diff_files(struct rev_info *revs, unsigned int option)
free(dpath); free(dpath);
continue; continue;
} }
free(dpath); FREE_AND_NULL(dpath);
dpath = NULL;


/* /*
* Show the diff for the 'ce' if we found the one * Show the diff for the 'ce' if we found the one

6
diff.c

@ -1218,8 +1218,7 @@ static void free_diff_words_data(struct emit_callback *ecbdata)
regfree(ecbdata->diff_words->word_regex); regfree(ecbdata->diff_words->word_regex);
free(ecbdata->diff_words->word_regex); free(ecbdata->diff_words->word_regex);
} }
free(ecbdata->diff_words); FREE_AND_NULL(ecbdata->diff_words);
ecbdata->diff_words = NULL;
} }
} }


@ -2951,8 +2950,7 @@ void diff_free_filespec_blob(struct diff_filespec *s)
void diff_free_filespec_data(struct diff_filespec *s) void diff_free_filespec_data(struct diff_filespec *s)
{ {
diff_free_filespec_blob(s); diff_free_filespec_blob(s);
free(s->cnt_data); FREE_AND_NULL(s->cnt_data);
s->cnt_data = NULL;
} }


static void prep_temp_blob(const char *path, struct diff_tempfile *temp, static void prep_temp_blob(const char *path, struct diff_tempfile *temp,

6
diffcore-rename.c

@ -667,11 +667,9 @@ void diffcore_rename(struct diff_options *options)
for (i = 0; i < rename_dst_nr; i++) for (i = 0; i < rename_dst_nr; i++)
free_filespec(rename_dst[i].two); free_filespec(rename_dst[i].two);


free(rename_dst); FREE_AND_NULL(rename_dst);
rename_dst = NULL;
rename_dst_nr = rename_dst_alloc = 0; rename_dst_nr = rename_dst_alloc = 0;
free(rename_src); FREE_AND_NULL(rename_src);
rename_src = NULL;
rename_src_nr = rename_src_alloc = 0; rename_src_nr = rename_src_alloc = 0;
return; return;
} }

9
dir.c

@ -2117,8 +2117,7 @@ int read_directory(struct dir_struct *dir, struct index_state *istate,
for (i = j = 0; j < dir->nr; j++) { for (i = j = 0; j < dir->nr; j++) {
if (i && if (i &&
check_dir_entry_contains(dir->entries[i - 1], dir->entries[j])) { check_dir_entry_contains(dir->entries[i - 1], dir->entries[j])) {
free(dir->entries[j]); FREE_AND_NULL(dir->entries[j]);
dir->entries[j] = NULL;
} else { } else {
dir->entries[i++] = dir->entries[j]; dir->entries[i++] = dir->entries[j];
} }
@ -2144,8 +2143,7 @@ int read_directory(struct dir_struct *dir, struct index_state *istate,
dir->untracked->dir_invalidated)) dir->untracked->dir_invalidated))
istate->cache_changed |= UNTRACKED_CHANGED; istate->cache_changed |= UNTRACKED_CHANGED;
if (dir->untracked != istate->untracked) { if (dir->untracked != istate->untracked) {
free(dir->untracked); FREE_AND_NULL(dir->untracked);
dir->untracked = NULL;
} }
} }
return dir->nr; return dir->nr;
@ -2488,8 +2486,7 @@ void write_untracked_extension(struct strbuf *out, struct untracked_cache *untra
strbuf_addbuf(out, &untracked->ident); strbuf_addbuf(out, &untracked->ident);


strbuf_add(out, ouc, ouc_size(len)); strbuf_add(out, ouc, ouc_size(len));
free(ouc); FREE_AND_NULL(ouc);
ouc = NULL;


if (!untracked->root) { if (!untracked->root) {
varint_len = encode_varint(0, varbuf); varint_len = encode_varint(0, varbuf);

6
fast-import.c

@ -1063,8 +1063,7 @@ discard_pack:
close(pack_data->pack_fd); close(pack_data->pack_fd);
unlink_or_warn(pack_data->pack_name); unlink_or_warn(pack_data->pack_name);
} }
free(pack_data); FREE_AND_NULL(pack_data);
pack_data = NULL;
running = 0; running = 0;


/* We can't carry a delta across packfiles. */ /* We can't carry a delta across packfiles. */
@ -1149,8 +1148,7 @@ static int store_object(


/* We cannot carry a delta into the new pack. */ /* We cannot carry a delta into the new pack. */
if (delta) { if (delta) {
free(delta); FREE_AND_NULL(delta);
delta = NULL;


git_deflate_init(&s, pack_compression_level); git_deflate_init(&s, pack_compression_level);
s.next_in = (void *)dat->buf; s.next_in = (void *)dat->buf;

3
grep.c

@ -1778,8 +1778,7 @@ void grep_source_clear_data(struct grep_source *gs)
case GREP_SOURCE_FILE: case GREP_SOURCE_FILE:
case GREP_SOURCE_SHA1: case GREP_SOURCE_SHA1:
case GREP_SOURCE_SUBMODULE: case GREP_SOURCE_SUBMODULE:
free(gs->buf); FREE_AND_NULL(gs->buf);
gs->buf = NULL;
gs->size = 0; gs->size = 0;
break; break;
case GREP_SOURCE_BUF: case GREP_SOURCE_BUF:

24
http-push.c

@ -291,8 +291,7 @@ static void start_mkcol(struct transfer_request *request)
request->state = RUN_MKCOL; request->state = RUN_MKCOL;
} else { } else {
request->state = ABORTED; request->state = ABORTED;
free(request->url); FREE_AND_NULL(request->url);
request->url = NULL;
} }
} }
#endif #endif
@ -409,8 +408,7 @@ static void start_put(struct transfer_request *request)
request->state = RUN_PUT; request->state = RUN_PUT;
} else { } else {
request->state = ABORTED; request->state = ABORTED;
free(request->url); FREE_AND_NULL(request->url);
request->url = NULL;
} }
} }


@ -432,8 +430,7 @@ static void start_move(struct transfer_request *request)
request->state = RUN_MOVE; request->state = RUN_MOVE;
} else { } else {
request->state = ABORTED; request->state = ABORTED;
free(request->url); FREE_AND_NULL(request->url);
request->url = NULL;
} }
} }


@ -526,8 +523,7 @@ static void finish_request(struct transfer_request *request)


/* URL is reused for MOVE after PUT */ /* URL is reused for MOVE after PUT */
if (request->state != RUN_PUT) { if (request->state != RUN_PUT) {
free(request->url); FREE_AND_NULL(request->url);
request->url = NULL;
} }


if (request->state == RUN_MKCOL) { if (request->state == RUN_MKCOL) {
@ -803,8 +799,7 @@ xml_start_tag(void *userData, const char *name, const char **atts)
} }
xsnprintf(ctx->name + old_namelen, ctx->len - old_namelen, ".%s", c); xsnprintf(ctx->name + old_namelen, ctx->len - old_namelen, ".%s", c);


free(ctx->cdata); FREE_AND_NULL(ctx->cdata);
ctx->cdata = NULL;


ctx->userFunc(ctx, 0); ctx->userFunc(ctx, 0);
} }
@ -932,8 +927,7 @@ static struct remote_lock *lock_remote(const char *path, long timeout)
free(lock->token); free(lock->token);
free(lock->owner); free(lock->owner);
free(url); free(url);
free(lock); FREE_AND_NULL(lock);
lock = NULL;
} else { } else {
lock->url = url; lock->url = url;
lock->start_time = time(NULL); lock->start_time = time(NULL);
@ -1105,8 +1099,7 @@ static void handle_remote_ls_ctx(struct xml_ctx *ctx, int tag_closed)
ls->dentry_flags |= IS_DIR; ls->dentry_flags |= IS_DIR;
} }
} else if (!strcmp(ctx->name, DAV_PROPFIND_RESP)) { } else if (!strcmp(ctx->name, DAV_PROPFIND_RESP)) {
free(ls->dentry_name); FREE_AND_NULL(ls->dentry_name);
ls->dentry_name = NULL;
ls->dentry_flags = 0; ls->dentry_flags = 0;
} }
} }
@ -1547,8 +1540,7 @@ static void fetch_symref(const char *path, char **symref, struct object_id *oid)
curl_errorstr); curl_errorstr);
free(url); free(url);


free(*symref); FREE_AND_NULL(*symref);
*symref = NULL;
oidclr(oid); oidclr(oid);


if (buffer.len == 0) if (buffer.len == 0)

15
http.c

@ -1026,8 +1026,7 @@ void http_cleanup(void)


if (proxy_auth.password) { if (proxy_auth.password) {
memset(proxy_auth.password, 0, strlen(proxy_auth.password)); memset(proxy_auth.password, 0, strlen(proxy_auth.password));
free(proxy_auth.password); FREE_AND_NULL(proxy_auth.password);
proxy_auth.password = NULL;
} }


free((void *)curl_proxyuserpwd); free((void *)curl_proxyuserpwd);
@ -1038,13 +1037,11 @@ void http_cleanup(void)


if (cert_auth.password != NULL) { if (cert_auth.password != NULL) {
memset(cert_auth.password, 0, strlen(cert_auth.password)); memset(cert_auth.password, 0, strlen(cert_auth.password));
free(cert_auth.password); FREE_AND_NULL(cert_auth.password);
cert_auth.password = NULL;
} }
ssl_cert_password_required = 0; ssl_cert_password_required = 0;


free(cached_accept_language); FREE_AND_NULL(cached_accept_language);
cached_accept_language = NULL;
} }


struct active_request_slot *get_active_slot(void) struct active_request_slot *get_active_slot(void)
@ -1896,8 +1893,7 @@ static char *fetch_pack_index(unsigned char *sha1, const char *base_url)


if (http_get_file(url, tmp, NULL) != HTTP_OK) { if (http_get_file(url, tmp, NULL) != HTTP_OK) {
error("Unable to get pack index %s", url); error("Unable to get pack index %s", url);
free(tmp); FREE_AND_NULL(tmp);
tmp = NULL;
} }


free(url); free(url);
@ -2328,8 +2324,7 @@ void release_http_object_request(struct http_object_request *freq)
freq->localfile = -1; freq->localfile = -1;
} }
if (freq->url != NULL) { if (freq->url != NULL) {
free(freq->url); FREE_AND_NULL(freq->url);
freq->url = NULL;
} }
if (freq->slot != NULL) { if (freq->slot != NULL) {
freq->slot->callback_func = NULL; freq->slot->callback_func = NULL;

3
imap-send.c

@ -776,8 +776,7 @@ static int get_cmd_result(struct imap_store *ctx, struct imap_cmd *tcmd)
offsetof(struct imap_cmd, next)); offsetof(struct imap_cmd, next));
if (cmdp->cb.data) { if (cmdp->cb.data) {
n = socket_write(&imap->buf.sock, cmdp->cb.data, cmdp->cb.dlen); n = socket_write(&imap->buf.sock, cmdp->cb.data, cmdp->cb.dlen);
free(cmdp->cb.data); FREE_AND_NULL(cmdp->cb.data);
cmdp->cb.data = NULL;
if (n != (int)cmdp->cb.dlen) if (n != (int)cmdp->cb.dlen)
return RESP_BAD; return RESP_BAD;
} else if (cmdp->cb.cont) { } else if (cmdp->cb.cont) {

3
line-log.c

@ -610,8 +610,7 @@ parse_lines(struct commit *commit, const char *prefix, struct string_list *args)
line_log_data_insert(&ranges, full_name, begin, end); line_log_data_insert(&ranges, full_name, begin, end);


free_filespec(spec); free_filespec(spec);
free(ends); FREE_AND_NULL(ends);
ends = NULL;
} }


for (p = ranges; p; p = p->next) for (p = ranges; p; p = p->next)

3
mailinfo.c

@ -919,8 +919,7 @@ again:
/* we hit an end boundary */ /* we hit an end boundary */
/* pop the current boundary off the stack */ /* pop the current boundary off the stack */
strbuf_release(*(mi->content_top)); strbuf_release(*(mi->content_top));
free(*(mi->content_top)); FREE_AND_NULL(*(mi->content_top));
*(mi->content_top) = NULL;


/* technically won't happen as is_multipart_boundary() /* technically won't happen as is_multipart_boundary()
will fail first. But just in case.. will fail first. But just in case..

3
object.c

@ -377,8 +377,7 @@ void object_array_clear(struct object_array *array)
int i; int i;
for (i = 0; i < array->nr; i++) for (i = 0; i < array->nr; i++)
object_array_release_entry(&array->objects[i]); object_array_release_entry(&array->objects[i]);
free(array->objects); FREE_AND_NULL(array->objects);
array->objects = NULL;
array->nr = array->alloc = 0; array->nr = array->alloc = 0;
} }



3
pathspec.c

@ -662,7 +662,6 @@ void clear_pathspec(struct pathspec *pathspec)
attr_check_free(pathspec->items[i].attr_check); attr_check_free(pathspec->items[i].attr_check);
} }


free(pathspec->items); FREE_AND_NULL(pathspec->items);
pathspec->items = NULL;
pathspec->nr = 0; pathspec->nr = 0;
} }

6
read-cache.c

@ -1888,8 +1888,7 @@ int discard_index(struct index_state *istate)
free_name_hash(istate); free_name_hash(istate);
cache_tree_free(&(istate->cache_tree)); cache_tree_free(&(istate->cache_tree));
istate->initialized = 0; istate->initialized = 0;
free(istate->cache); FREE_AND_NULL(istate->cache);
istate->cache = NULL;
istate->cache_alloc = 0; istate->cache_alloc = 0;
discard_split_index(istate); discard_split_index(istate);
free_untracked_cache(istate->untracked); free_untracked_cache(istate->untracked);
@ -2603,8 +2602,7 @@ void *read_blob_data_from_index(const struct index_state *istate,


void stat_validity_clear(struct stat_validity *sv) void stat_validity_clear(struct stat_validity *sv)
{ {
free(sv->sd); FREE_AND_NULL(sv->sd);
sv->sd = NULL;
} }


int stat_validity_check(struct stat_validity *sv, const char *path) int stat_validity_check(struct stat_validity *sv, const char *path)

3
ref-filter.c

@ -1891,8 +1891,7 @@ void ref_array_clear(struct ref_array *array)


for (i = 0; i < array->nr; i++) for (i = 0; i < array->nr; i++)
free_array_item(array->items[i]); free_array_item(array->items[i]);
free(array->items); FREE_AND_NULL(array->items);
array->items = NULL;
array->nr = array->alloc = 0; array->nr = array->alloc = 0;
} }



3
refs/files-backend.c

@ -2944,8 +2944,7 @@ static int files_transaction_prepare(struct ref_store *ref_store,
head_oid.hash, &head_type); head_oid.hash, &head_type);


if (head_ref && !(head_type & REF_ISSYMREF)) { if (head_ref && !(head_type & REF_ISSYMREF)) {
free(head_ref); FREE_AND_NULL(head_ref);
head_ref = NULL;
} }


/* /*

3
remote-testsvn.c

@ -66,8 +66,7 @@ static char *read_ref_note(const unsigned char sha1[20])
else if (!msglen || type != OBJ_BLOB) { else if (!msglen || type != OBJ_BLOB) {
error("Note contains unusable content. " error("Note contains unusable content. "
"Is something else using this notes tree? %s", notes_ref); "Is something else using this notes tree? %s", notes_ref);
free(msg); FREE_AND_NULL(msg);
msg = NULL;
} }
free_notes(NULL); free_notes(NULL);
return msg; return msg;

3
sequencer.c

@ -1211,8 +1211,7 @@ struct todo_list {
static void todo_list_release(struct todo_list *todo_list) static void todo_list_release(struct todo_list *todo_list)
{ {
strbuf_release(&todo_list->buf); strbuf_release(&todo_list->buf);
free(todo_list->items); FREE_AND_NULL(todo_list->items);
todo_list->items = NULL;
todo_list->nr = todo_list->alloc = 0; todo_list->nr = todo_list->alloc = 0;
} }



3
sha1-array.c

@ -35,8 +35,7 @@ int oid_array_lookup(struct oid_array *array, const struct object_id *oid)


void oid_array_clear(struct oid_array *array) void oid_array_clear(struct oid_array *array)
{ {
free(array->oid); FREE_AND_NULL(array->oid);
array->oid = NULL;
array->nr = 0; array->nr = 0;
array->alloc = 0; array->alloc = 0;
array->sorted = 0; array->sorted = 0;

3
sha1_file.c

@ -610,8 +610,7 @@ char *compute_alternate_path(const char *path, struct strbuf *err)


out: out:
if (seen_error) { if (seen_error) {
free(ref_git); FREE_AND_NULL(ref_git);
ref_git = NULL;
} }


return ref_git; return ref_git;

27
transport-helper.c

@ -242,8 +242,7 @@ static int disconnect_helper(struct transport *transport)
close(data->helper->out); close(data->helper->out);
fclose(data->out); fclose(data->out);
res = finish_command(data->helper); res = finish_command(data->helper);
free(data->helper); FREE_AND_NULL(data->helper);
data->helper = NULL;
} }
return res; return res;
} }
@ -711,43 +710,35 @@ static int push_update_ref_status(struct strbuf *buf,


if (!strcmp(msg, "no match")) { if (!strcmp(msg, "no match")) {
status = REF_STATUS_NONE; status = REF_STATUS_NONE;
free(msg); FREE_AND_NULL(msg);
msg = NULL;
} }
else if (!strcmp(msg, "up to date")) { else if (!strcmp(msg, "up to date")) {
status = REF_STATUS_UPTODATE; status = REF_STATUS_UPTODATE;
free(msg); FREE_AND_NULL(msg);
msg = NULL;
} }
else if (!strcmp(msg, "non-fast forward")) { else if (!strcmp(msg, "non-fast forward")) {
status = REF_STATUS_REJECT_NONFASTFORWARD; status = REF_STATUS_REJECT_NONFASTFORWARD;
free(msg); FREE_AND_NULL(msg);
msg = NULL;
} }
else if (!strcmp(msg, "already exists")) { else if (!strcmp(msg, "already exists")) {
status = REF_STATUS_REJECT_ALREADY_EXISTS; status = REF_STATUS_REJECT_ALREADY_EXISTS;
free(msg); FREE_AND_NULL(msg);
msg = NULL;
} }
else if (!strcmp(msg, "fetch first")) { else if (!strcmp(msg, "fetch first")) {
status = REF_STATUS_REJECT_FETCH_FIRST; status = REF_STATUS_REJECT_FETCH_FIRST;
free(msg); FREE_AND_NULL(msg);
msg = NULL;
} }
else if (!strcmp(msg, "needs force")) { else if (!strcmp(msg, "needs force")) {
status = REF_STATUS_REJECT_NEEDS_FORCE; status = REF_STATUS_REJECT_NEEDS_FORCE;
free(msg); FREE_AND_NULL(msg);
msg = NULL;
} }
else if (!strcmp(msg, "stale info")) { else if (!strcmp(msg, "stale info")) {
status = REF_STATUS_REJECT_STALE; status = REF_STATUS_REJECT_STALE;
free(msg); FREE_AND_NULL(msg);
msg = NULL;
} }
else if (!strcmp(msg, "forced update")) { else if (!strcmp(msg, "forced update")) {
forced = 1; forced = 1;
free(msg); FREE_AND_NULL(msg);
msg = NULL;
} }
} }



3
transport.c

@ -1145,8 +1145,7 @@ void transport_unlock_pack(struct transport *transport)
{ {
if (transport->pack_lockfile) { if (transport->pack_lockfile) {
unlink_or_warn(transport->pack_lockfile); unlink_or_warn(transport->pack_lockfile);
free(transport->pack_lockfile); FREE_AND_NULL(transport->pack_lockfile);
transport->pack_lockfile = NULL;
} }
} }



6
tree-diff.c

@ -140,8 +140,7 @@ static struct combine_diff_path *path_appendnew(struct combine_diff_path *last,
/* if last->next is !NULL - it is a pre-allocated memory, we can reuse */ /* if last->next is !NULL - it is a pre-allocated memory, we can reuse */
p = last->next; p = last->next;
if (p && (alloclen > (intptr_t)p->next)) { if (p && (alloclen > (intptr_t)p->next)) {
free(p); FREE_AND_NULL(p);
p = NULL;
} }


if (!p) { if (!p) {
@ -559,8 +558,7 @@ struct combine_diff_path *diff_tree_paths(
* (see path_appendnew() for details about why) * (see path_appendnew() for details about why)
*/ */
if (p->next) { if (p->next) {
free(p->next); FREE_AND_NULL(p->next);
p->next = NULL;
} }


return p; return p;

3
tree.c

@ -226,8 +226,7 @@ int parse_tree_gently(struct tree *item, int quiet_on_missing)


void free_tree_buffer(struct tree *tree) void free_tree_buffer(struct tree *tree)
{ {
free(tree->buffer); FREE_AND_NULL(tree->buffer);
tree->buffer = NULL;
tree->size = 0; tree->size = 0;
tree->object.parsed = 0; tree->object.parsed = 0;
} }

Loading…
Cancel
Save