From 697bc8858114ddda705be6f6eb3f997b64efa659 Mon Sep 17 00:00:00 2001 From: Brandon Casey Date: Sun, 17 Sep 2017 15:28:17 -0700 Subject: [PATCH] git-rebase: don't ignore unexpected command line arguments Currently, git-rebase will silently ignore any unexpected command-line switches and arguments (the command-line produced by git rev-parse). This allowed the rev-parse bug, fixed in the preceding commits, to go unnoticed. Let's make sure that doesn't happen again. We shouldn't be ignoring unexpected arguments. Let's not. Signed-off-by: Brandon Casey Signed-off-by: Junio C Hamano --- git-rebase.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/git-rebase.sh b/git-rebase.sh index 2cf73b88e8..45f187bdbf 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -348,6 +348,9 @@ do shift break ;; + *) + usage + ;; esac shift done