Browse Source

poll.c: always set revents, even if to zero

Match what is done to pfd[i].revents when compute_revents() returns
0 to the upstream gnulib's commit d42461c3 ("poll: fixes for large
fds", 2015-02-20).  The revents field is set to 0, without
incrementing the value rc to be returned from the function.  The
original code left the field to whatever random value the field was
initialized to.

This fixes occasional hangs in git-upload-pack on HPE NonStop.

Signed-off-by: Randall S. Becker <randall.becker@nexbridge.ca>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Randall S. Becker 7 years ago committed by Junio C Hamano
parent
commit
61b2a1acaa
  1. 4
      compat/poll/poll.c

4
compat/poll/poll.c

@ -438,6 +438,10 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout) @@ -438,6 +438,10 @@ poll (struct pollfd *pfd, nfds_t nfd, int timeout)
pfd[i].revents = happened;
rc++;
}
else
{
pfd[i].revents = 0;
}
}

return rc;

Loading…
Cancel
Save