Browse Source

CodingGuidelines: do not ==/!= compare with 0 or '\0' or NULL

Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Junio C Hamano 5 years ago
parent
commit
5c7bb0146e
  1. 12
      Documentation/CodingGuidelines

12
Documentation/CodingGuidelines

@ -238,6 +238,18 @@ For C programs: @@ -238,6 +238,18 @@ For C programs:
while( condition )
func (bar+1);

- Do not explicitly compare an integral value with constant 0 or '\0',
or a pointer value with constant NULL. For instance, to validate that
counted array <ptr, cnt> is initialized but has no elements, write:

if (!ptr || cnt)
BUG("empty array expected");

and not:

if (ptr == NULL || cnt != 0);
BUG("empty array expected");

- We avoid using braces unnecessarily. I.e.

if (bla) {

Loading…
Cancel
Save