kernel
/
git
mirror of https://git.kernel.org/pub/scm/git/git.git
1
0
Fork 0
Code Releases Activity

cvsimport: shell-quote variable used in backticks 

We run `git rev-parse` though the shell, and quote its
argument only with single-quotes. This prevents most
metacharacters from being a problem, but misses the obvious
case when $name itself has single-quotes in it. We can fix
this by applying the usual shell-quoting formula.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
maint
Jeff King 2017-09-11 10:24:26 -04:00 committed by Junio C Hamano
parent 4d4165b80d
commit 5b4efea666
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
git-cvsimport.perl
View File

@ -642,6 +642,7 @@ sub is_sha1 {


sub get_headref ($) { sub get_headref ($) {
my $name = shift; my $name = shift;
$name =~ s/'/'\\''/;
my $r = `git rev-parse --verify '$name' 2>/dev/null`; my $r = `git rev-parse --verify '$name' 2>/dev/null`;
return undef unless $? == 0; return undef unless $? == 0;
chomp $r; chomp $r;