Browse Source

Merge branch 'jc/strbuf-add-lines-avoid-sp-ht-sequence'

The commented output used to blindly add a SP before the payload
line, resulting in "# \t<indented text>\n" when the payload began
with a HT.  Instead, produce "#\t<indented text>\n".

* jc/strbuf-add-lines-avoid-sp-ht-sequence:
  strbuf_add_commented_lines(): avoid SP-HT sequence in commented lines
maint
Junio C Hamano 10 years ago
parent
commit
58e0362edd
  1. 3
      strbuf.c
  2. 6
      t/t0030-stripspace.sh

3
strbuf.c

@ -229,7 +229,8 @@ static void add_lines(struct strbuf *out, @@ -229,7 +229,8 @@ static void add_lines(struct strbuf *out,
const char *next = memchr(buf, '\n', size);
next = next ? (next + 1) : (buf + size);

prefix = (prefix2 && buf[0] == '\n') ? prefix2 : prefix1;
prefix = ((prefix2 && (buf[0] == '\n' || buf[0] == '\t'))
? prefix2 : prefix1);
strbuf_addstr(out, prefix);
strbuf_add(out, buf, next - buf);
size -= next - buf;

6
t/t0030-stripspace.sh

@ -432,4 +432,10 @@ test_expect_success '-c with changed comment char' ' @@ -432,4 +432,10 @@ test_expect_success '-c with changed comment char' '
test_cmp expect actual
'

test_expect_success 'avoid SP-HT sequence in commented line' '
printf "#\tone\n#\n# two\n" >expect &&
printf "\tone\n\ntwo\n" | git stripspace -c >actual &&
test_cmp expect actual
'

test_done

Loading…
Cancel
Save