Browse Source

Merge branch 'lc/shell-default-value-noexpand' into maint

Fix unnecessarily waste in the idiomatic use of ': ${VAR=default}'
to set the default value, without enclosing it in double quotes.

* lc/shell-default-value-noexpand:
  sh-setup: enclose setting of ${VAR=default} in double-quotes
maint
Junio C Hamano 9 years ago
parent
commit
5220b7589b
  1. 6
      git-sh-setup.sh

6
git-sh-setup.sh

@ -160,8 +160,8 @@ git_pager() { @@ -160,8 +160,8 @@ git_pager() {
else
GIT_PAGER=cat
fi
: ${LESS=-FRX}
: ${LV=-c}
: "${LESS=-FRX}"
: "${LV=-c}"
export LESS LV

eval "$GIT_PAGER" '"$@"'
@ -344,7 +344,7 @@ git_dir_init () { @@ -344,7 +344,7 @@ git_dir_init () {
echo >&2 "Unable to determine absolute path of git directory"
exit 1
}
: ${GIT_OBJECT_DIRECTORY="$(git rev-parse --git-path objects)"}
: "${GIT_OBJECT_DIRECTORY="$(git rev-parse --git-path objects)"}"
}

if test -z "$NONGIT_OK"

Loading…
Cancel
Save